Re: [PATCH net-next v2] net: sunplus: also fix the byte order of 1c:50:1e MAC addresses
From: Andrew Lunn
Date: Fri Nov 20 2026 - 08:01:27 EST
On Fri, Nov 20, 2026 at 09:39:01AM +0200, Andrew Gaylard wrote:
> The driver reverses a MAC address from the OTP when it finds the
> Sunplus OUI fc:4b:bc at the wrong end. Newer SP7021 chips have
> a different Sunplus OUI (1c:50:1e), possibly stored in the same
> reversed order, which the driver does not recognise. If the reversed
> address has the multicast bit set, the driver rejects it and uses a
> random address; otherwise it uses the reversed address as it is.
>
> Handle both these OUIs. An address that already starts with either OUI
> is left as is. On chips that used the reversed address, the interface
> now gets the correct address, so configuration tied to the old address
> (DHCP reservations, udev or networkd rules) will need updating.
>
> Tested on chips that needed each of these OUIs to be reversed.
>
> Reviewed-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Gaylard <ag@xxxxxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew