Re: [PATCH rtw-next v3 1/5] wifi: rtw88: free the reserved pages of an interface on firmware recovery
From: Luka Gejak
Date: Fri Nov 20 2026 - 08:10:33 EST
Hi Mehmet,
Thanks for the update. Two comments below.
On November 17, 2026 6:09:59 PM GMT+01:00, Mehmet Fide
<mehmet.fide@xxxxxxxxx> wrote:
> @@ -1765,6 +1768,9 @@ int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
> u32 size;
> int ret;
>
> + if (bitmap_empty(rtwdev->hw_port, RTW_PORT_NUM))
> + return 0;
> +
> buf = rtw_build_rsvd_page(rtwdev, &size);
Could this skip a download that WoWLAN needs? If suspend flushes the
recovery work while it holds RTNL, ieee80211_restart_work() cannot add
the interfaces back before rtw_wow_suspend() runs. With net detect
configured, the station interface can still be picked for WoWLAN.
rtw_wow_leave_no_link_ps() can power the device back up without setting
the port bitmap again.
So rtw_wow_config_wow_fw_rsvd_page() adds the scan pages, but the check
above returns success before downloading them. rtw_wow_fw_start() then
tries to enable net detect with a zero page location for the NLO and
channel tables. Could we keep the skip in the beacon update paths, or
have suspend fall back to the normal suspend path when a restart is
pending?
[ ... ]
> @@ -633,6 +633,7 @@ static void rtw_reset_vif_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
> rtw_bf_disassoc(rtwdev, vif, NULL);
> rtw_vif_assoc_changed(rtwvif, NULL);
> rtw_txq_cleanup(rtwdev, vif->txq);
> + rtw_remove_rsvd_page(rtwdev, rtwvif);
I think the empty list warning can still happen with AP and station
interfaces on the RTL8822C. If a station interface comes up after the
reset clears the bitmap, rtw_ops_add_interface() sets a port before
ieee80211_do_open() marks the interface running. The AP still has an
empty list, and the page iterator skips the station interface until it
is running.
Can a TIM update from the AP run in that gap? For example, the station
cleanup timer can expire a buffered frame after rtw_core_stop() cancels
the beacon work. The worker can then see a port in use and still hit
"Should not have an empty reserved page". Would it make sense to free
the old pages before reinitializing the list when adding an interface
that was already initialized, as Zong-Zhe suggested?
https://lore.kernel.org/linux-wireless/96da951407ab4c39b7e229ca365950eb@xxxxxxxxxxx/
Best regards,
Luka Gejak