Re: [PATCH rtw-next v3 2/5] wifi: rtw88: report the frames purged from the TX report queue
From: Luka Gejak
Date: Fri Nov 20 2026 - 08:10:47 EST
Hi Mehmet,
Thanks for the patch. One comment below.
On November 17, 2026 6:10:00 PM GMT+01:00, Mehmet Fide
<mehmet.fide@xxxxxxxxx> wrote:
> + spin_lock_irqsave(&tx_report->q_lock, flags);
> + skb_queue_splice_init(&tx_report->queue, &purge);
> + spin_unlock_irqrestore(&tx_report->q_lock, flags);
> +
> + ieee80211_purge_tx_queue(rtwdev->hw, &purge);
As far as I can see, an AP peer probe that times out can report an ACK
signal and a link ID from the old TX control fields. On x86_64,
status.flags and status.link_valid overlap control.vif. The firmware
report path clears the status before handing the skb back, but the
purge path passes it straight to mac80211. The timer can do this while
the AP is still up.
ieee80211_report_ack_skb() reads those fields for a null frame even
when it was dropped. cfg80211_probe_status() can then include both
attributes in the event without an ACK. Could we clear the TX status in
rtw_tx_report_enqueue() before saving the sequence number?
Best regards,
Luka Gejak