Re: [PATCH net-next v2] net: phy: air_en8811h: check PBUS register read errors
From: Andrew Lunn
Date: Fri Nov 20 2026 - 08:15:38 EST
> /* We do not know what errors this check is supposed
> * catch or what to do about a failure. So print the
> * result and continue like the vendor driver does.
> */
> if (pbus_value & AN8811HB_CRC_ST) {
> - air_phy_buckpbus_reg_read(phydev, mon3, &pbus_value);
> + ret = air_phy_buckpbus_reg_read(phydev, mon3,
> + &pbus_value);
> + if (ret < 0)
> + return ret;
Please could you explain your understanding how this change and the
comment go together? You did read the comment didn't you?
Andrew