Re: [PATCH] USB: cdc-acm: refuse writes after disconnect

From: Greg Kroah-Hartman

Date: Fri Nov 20 2026 - 08:45:51 EST


On Fri, Nov 20, 2026 at 12:22:30PM +0100, Johan Hovold wrote:
> On Wed, Nov 18, 2026 at 02:56:36PM +0000, William A. Kennington III wrote:
> > Commit 7fb57a019f94 ("USB: cdc-acm: Fix potential deadlock (lockdep
> > warning)") stopped clearing acm->dev in acm_disconnect() and replaced
> > ACM_READY() with acm->disconnected, but left the write path checking
> > !acm->dev and dropped the disconnect check from acm_tty_write_room().
> > Because acm_disconnect() frees the write buffers with
> > usb_free_coherent() and acm_probe() only pins acm->control, a late
> > acm_tty_write() call dereferences freed memory.
> >
> > This can happen when a CDC-ACM device disconnects while a file
> > descriptor remains open with a line discipline such as mctp-serial
> > attached. Hangup closes the line discipline, but a subsequent reopen of
> > the hung-up TTY calls tty_reopen() -> tty_ldisc_reinit() from the saved
> > c_line before acm_tty_open() fails with -ENODEV. Because the original
> > descriptor keeps tty->count non-zero, the reinitialized mctp-serial
> > instance stays attached and faults in memcpy() inside acm_tty_write() on
> > the freed wb->buf when transmitting.
>
> Thanks for reporting this. I assume this is not something you actually
> hit yourself but rather something flagged by an LLM?
>
> > Pin acm->data alongside acm->control until acm_port_destruct() so the
> > unlocked dev_vdbg() in acm_tty_write() stays valid across disconnect,
> > check acm->disconnected at the start of the write_lock critical section,
> > report zero room in acm_tty_write_room() once disconnected, and set
> > acm->disconnected under write_lock in acm_disconnect() so any concurrent
> > writer finishes before the URBs are poisoned and the buffers are freed.
>
> This isn't the right fix though as the line disciplines should not be
> calling back into the driver after a hangup (and this isn't cdc-acm
> specific).
>
> I've prepared a fix that restores the ldisc to N_TTY when a tty is
> reopened after a hangup instead.

Argh, I grabbed this too soon, I'll go revert it...