Re: [RFC PATCH 3/4] drm/tilcdc: Implement state readout support

From: Maxime Ripard

Date: Fri Nov 20 2026 - 09:02:00 EST


On Wed, Nov 18, 2026 at 10:21:14PM +0100, Màxim Pedraza Padilla wrote:
> On Mon, Nov 16, 2026 at 06:12:50PM +0100, Maxime Ripard wrote:
> > > - tilcdc_crtc_mode_fixup() is undone to get the requested mode, but a
> > > positive sync can't be told from a mode that doesn't specify it.
> >
> > That's suprising as well, the polairity of signals is typically stored
> > somewhere in a register.
>
> It is, in RASTER_TIMING_2 (INVERT_HSYNC and INVERT_VSYNC), so the actual
> polarity is read back fine. What's lost is the difference between a mode
> that asks for DRM_MODE_FLAG_PHSYNC and one with no polarity flag at all:
> both end up with the same register value, and the readout can only pick
> one of them. I'll reword the commit message.

I think the real solution in this case is to fix the panel to report its
polarity properly.

Thanks again,
Maxime

Attachment: signature.asc
Description: PGP signature