Re: [PATCH] ACPI: APEI: EINJ: Validate length of the Vendor Error Type Extension structure

From: Rafael J. Wysocki (Intel)

Date: Fri Nov 20 2026 - 09:10:01 EST


On Fri, Nov 13, 2026 at 10:37 AM Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
>
> On Fri, 13 Nov 2026 00:27:20 +0000
> "Luck, Tony" <tony.luck@xxxxxxxxx> wrote:
>
> > > The BIOS on my machine is obviously buggy (non-zero Vendor Extension offset
> > > pointing to zeroed memory, and bit 31 is not set in the error type either)
> > > and needs fixing. I'm not sure if it is necessary to add such a sanity
> > > check for EINJ at all.
> >
> > Production machine? Or just an internal development machine? I.e. is this broken
> > BIOS out in the wild for others to hit this bug?
>
> As a reminder, any VM runs with a BIOS that is not produced by an OEM, and
> there are lots of production environments running VMs out there.
>
> So, I'd say that, if the fix is good, better apply it.
>
> From my side:
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

Applied as 7.5 material, thanks!