Re: [PATCH] ASoC: SDCA: Use Function Extension info for FDL
From: Maciej Strozek
Date: Fri Nov 20 2026 - 09:17:37 EST
W dniu śro, 18.11.2026 o godzinie 10∶54 +0000, użytkownik Charles
Keepax napisał:
> On Tue, Nov 17, 2026 at 02:48:53PM +0000, Maciej Strozek wrote:
> >
> > - disk_filename = fdl_get_sku_filename(dev, fdl_file);
> > - if (!disk_filename)
> > - return -ENOMEM;
> > + ret = fdl_get_sku_filename(interrupt, fdl_file,
> > + &disk_filename, &fallback_filename);
> > + if (ret)
> > + return ret;
> >
> > dev_dbg(dev, "FDL disk filename: %s\n", disk_filename);
>
> We should probably drop these FDL disk filename prints since the
> filename is now printed through source anyway.
> >
Yes, in case it finds the file, but I think it might be useful to know
what it attempted to read for debugging if it fails. Would moving those
prints inside the (!swf) case be better?
>
--
Regards,
Maciej