Re: [PATCH v4 0/2] ACPI: platform: ACPI 6.5 fixed clock support

From: Rafael J. Wysocki (Intel)

Date: Fri Nov 20 2026 - 09:25:56 EST


On Fri, Nov 20, 2026 at 3:24 PM Rafael J. Wysocki (Intel)
<rafael@xxxxxxxxxx> wrote:
>
> On Fri, Nov 20, 2026 at 1:57 PM Paul Cercueil <paul.cercueil@xxxxxxxxxxx> wrote:
> >
> > Hi Rafael, Russell,
> >
> > Here's the v4 of my patchset that adds partial support for ACPI 6.5
> > clock resources.
> >
> > Sashiko complained about the clock names being too long still, as
> > ACPI device names can be up to 17 characters and the limit of clock
> > names is 16 characters; so I now name them "acpi-clkX".
> >
> > Note that I expect warnings from Sashiko that I got on my v3 and didn't
> > correct, because they are bogus.
> >
> > On the clkdev patch:
> > "When clk_find(dev_id, NULL) is called, does incrementing match here
> > give a (dev_id, con_id) entry a higher score than an exact
> > (dev_id, NULL) entry?"
> >
> > My answer is that you call clk_find(dev_id, NULL) when you know you only
> > have one clock provided, so you don't need to care about matching
> > priorities.
> >
> > On the ACPI patch:
> > "Should the con_id argument to devm_clk_hw_register_clkdev() be NULL
> > instead of name? [...] Setting con_id to "<dev_name>-<idx>" instead of
> > NULL prevents wildcard connection matching in clk_find(), so any
> > consumer driver calling clk_get(dev, con_id) with a non-NULL con_id
> > fails with -ENOENT."
> >
> > That's completely ignoring the first patch, which addresses this issue.
> >
> > So I consider that those two issues can be ignored.
> >
> > Changelog since v3:
> >
> > - [2/2]:
> > - Change clock names to "acpi-clkX", because ACPI devices names can be
> > up to 17 characters long, and our clock name must be 16 characters
> > max.
> >
> > Cheers,
> > -Paul
> >
> > Paul Cercueil (2):
> > clkdev: Improve clock discovery with clk_find()
> > ACPI: platform: Add basic support for ACPI 6.5 fixed clock resources
> >
> > drivers/acpi/acpi_platform.c | 64 ++++++++++++++++++++++++++++++++++++
> > drivers/clk/clkdev.c | 4 ++-
> > 2 files changed, 67 insertions(+), 1 deletion(-)
> >
> > --
>
> Sashiko has feedback on this series:
>
> https://sashiko.dev/#/patchset/20261120125722.209609-1-paul.cercueil%40bootlin.com
>
> Please let me know what you think about it.

Ah, you've already done it, sorry for the noise!