Re: [PATCH 0/2] x86/mm/pat: HIGHMEM pages in set_pages_array_*()

From: Dave Hansen

Date: Fri Nov 20 2026 - 10:14:42 EST


On 11/19/26 23:50, Christian wrote:
> On 11/19/26 11:45, Dave Hansen wrote:
>> Reproduce upstream and we'll talk.
> vgem does it. It keeps its buffers in shmem pages (GFP_HIGHUSER) and sets
> map_wc, so on x86 mmap() reaches set_pages_array_wc() through
> drm_gem_shmem_get_pages_locked(). On i386 without PAE, once RAM is above
> lowmem, those pages are HIGHMEM.

I congratulate your LLM and mourn the tokens that were sacrificed for this.

I'll say, though, for something this obscure, I really need to be
convinced that it's not going to regress anything. I also want to know
that you'll be around to help us fix this if you break something.

Please spend some time on the changelogs and please do double-check that
there wasn't a better way to have done this. Human, please. No LLMs.