Re: [PATCH RFC v2] bus: mhi: host: pci_generic: Add MBIM-mode config for generic SDX65

From: Jeff Hugo

Date: Fri Nov 20 2026 - 11:38:07 EST


On 11/16/2026 8:08 PM, Haipeng Lin wrote:
On 11/13/26 1:53 PM, Jeff Hugo wrote:
On 11/10/2026 6:06 PM, Haipeng Lin via B4 Relay wrote:
From: Haipeng Lin <jimmie.lin@xxxxxxxxx>
[...]>> Boards with a Qualcomm-ID modem in MBIM mode have so far been told
apart by subsystem ID, like the SC8280XP CRD's SDX55 (17cb:010c).
This modem carries the generic subsystem ID, so select an MBIM
configuration by machine compatible instead.
I'd like it if we could query the hardware to determine if it is in this mode as maybe one of these systems has a SDX65 dongle attached where this workaround does not apply.  However, I am failing to identify such a mechanism so what you have proposed seem to be the best solution so far.

Unless someone identifies a better idea, this seems reasonable given the situation.

-Jeff

Hi Jeff,

Thank you for your reply. I tried to look for a hardware hint since we
have to select the channel layout before opening a channel (so that
can't be the way to select MBIM, I think). The oem_pk_hash on this SP11
SDX65 is non-zero (12 words) so it could potentially tell this module
apart from a dongle, but using it would mean reading BHI before the
controller is registered plus adding a table of hashes in the driver.

I can try the hash route if preferred. The machine match is simpler
although it wouldn't cover the situation e.g., a SDX65 dongle is attach-
ed via PCIe tunneling/USB4 you mentioned...
No, I don't think that is better. The pk_hash is just what firmware signature the device will accept as valid, but does not directly relate to the capabilities of the firmware or hardware. Trying to tie this workaround to that feels like an abuse of the meaning of that register, which I would be concerned would lead to some horribly broken corner case.

Without additional data, I think you move forward with what you have but it is really up to Mani if he'd accept this or would like something different.

-Jeff