Re: [PATCH v6 0/7] Clk improvements

From: Jerome Brunet

Date: Fri Nov 20 2026 - 11:48:50 EST


On 2026-11-11 13:54:01-03:00, Daniel Almeida wrote:
> Hi all,
>
> > This series contains a few improvements that simplify clock handling for
> > drivers.
> >
> > Patch 1 converts clk.rs to the kernel-vertical style for imports.
> >
> > Patch 2 replaces OptionalClk with Clk::get_optional(). There is no struct
> > optional_clk in C, and Clk already allows a NULL pointer.
> >
> > Patch 3 implements the same typestate pattern that has been used
> > successfully for Regulators. This is needed because otherwise drivers
> > will be responsible for unpreparing and disabling clocks themselves and
> > ultimately handling the reference counts on their own. This is
> > undesirable. The patch automatically encodes this information using the
> > type system so that no misuse can occur.
> >
> > Patch 4 adds guards that prepare and/or enable a clock for the lifetime
> > of the guard without consuming the Clk, so that a driver can keep a
> > long-lived Clk<Prepared> and enable it for scoped sections.
> >
> > Patch 5 makes things more convenient by offering devres-managed APIs. This
> > lets drivers set clock parameters once and forget about lifetime
> > management.
> >
> > Patch 6 adds ExclusiveClk<T>, which holds rate exclusivity over a Clk<T>
> > in any state until it is dropped.
> >
> > Patch 7 uses it in pwm-th1520 to lock the clock rate for the lifetime of
> > the driver data.

Hi there,

I was wondering how the rust folks expect these changes to be handled since they
touch the rust/ dir. Should the clock changes go through the clock tree or the
rust one ? it is fine with me either way.

I've added small comments on patch 3, with my understanding of what of what you
are trying to do. Please take them with a grain of salt. While I'm eager to help
rust grow in the kernel, I'm definetely very new to it. It is very likely I got
things wrong.

If there are pain points regarding clocks with Rust, please feel free to
reach me or Brian. We are happy to help if we can.

Cheers

--
Jerome