Re: [PATCH v3 14/14] suspend: fix duplicate extern declarations
From: Rafael J. Wysocki (Intel)
Date: Fri Nov 20 2026 - 12:25:40 EST
On Sat, Nov 14, 2026 at 5:57 PM Safocl Stollmannovic <safocl88@xxxxxxxxx> wrote:
>
> Compiling a kernel module with a C++ compiler results in a "duplicate
> extern specifier" error.
> This occurs because the code contains `extern asmlinkage`, and `asmlinkage`
> expands to `extern C` when processed by a C++ compiler.
> Since the code already contains sections that respond to a C++ compiler,
> I believe it is a perfectly valid approach to gradually move toward a state
> where kernel modules can be compiled by a C++ compiler without any issues.
> The `extern` specifier must be removed.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=222257
> Signed-off-by: Safocl Stollmannovic <safocl88@xxxxxxxxx>
> ---
> include/linux/suspend.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index a38150277..b97af3420 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -385,8 +385,8 @@ extern int swsusp_page_is_forbidden(struct page *);
> extern void swsusp_set_page_free(struct page *);
> extern void swsusp_unset_page_free(struct page *);
> extern unsigned long get_safe_page(gfp_t gfp_mask);
> -extern asmlinkage int swsusp_arch_suspend(void);
> -extern asmlinkage int swsusp_arch_resume(void);
> +asmlinkage int swsusp_arch_suspend(void);
> +asmlinkage int swsusp_arch_resume(void);
>
> extern u32 swsusp_hardware_signature;
> extern void hibernation_set_ops(const struct platform_hibernation_ops *ops);
> --
Applied as 7.5 material, thanks!