Re: [PATCH v2 19/24] dt-bindings: spi: Add ZTE ZX family SPI flash controller binding

From: Conor Dooley

Date: Fri Nov 20 2026 - 12:26:56 EST


On Fri, Nov 20, 2026 at 03:28:09PM +0000, Mark Brown wrote:
> > Add Device Tree binding for the ZTE ZX family SPI flash controller,
> > supporting both ZX29 and ZX279128S SoCs.
>
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
>
> > +properties:
> > + compatible:
> > + enum:
> > + - zte,zx29-qspi
>
> This looks like a wildcard binding which we don't normally allow.

I figure by wildcard you mean that the compatible is covering the whole
family, rather than the x being a wildcard character. If so, I agree
that it should not be allowed. I don't really know why it is here, no
other patch in the series that I looked at seems to do anything of the
sort, it's all device-specific ones for the xz279128s.

Attachment: signature.asc
Description: PGP signature