[PATCH] media: atomisp: Fix potential firmware leak after partial loading

From: Guangshuo Li

Date: Fri Nov 20 2026 - 12:35:39 EST


A failed firmware load can leave the minibuffer table and successfully
loaded blob parameters allocated. Probe skips firmware unload, and a
later retry overwrites the pointers to those allocations.

Unload partial firmware before freeing the IRQ. Clear all_binaries after
freeing it so cleanup after a later failed load cannot free the old
allocation again.

This issue was found by our static analysis tool under development.

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++--
drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index f8875d2b581b..4917d6bae44d 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1423,7 +1423,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
err = atomisp_css_load_firmware(isp);
if (err) {
dev_err(&pdev->dev, "Failed to init css.\n");
- goto error_free_irq;
+ goto error_unload_css;
}
/* Clear FW image from memory */
release_firmware(isp->firmware);
@@ -1442,8 +1442,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i

error_unload_firmware:
atomisp_pm_uninit(isp);
+error_unload_css:
ia_css_unload_firmware();
-error_free_irq:
devm_free_irq(&pdev->dev, pdev->irq, isp);
error_unregister_entities:
hmm_cleanup();
diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
index e9016d7775dc..8fe22eff24a1 100644
--- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
+++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
@@ -511,6 +511,7 @@ int ia_css_binary_uninit(void)
binary_infos[i] = NULL;
}
kvfree(all_binaries);
+ all_binaries = NULL;
return 0;
}


base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4