[PATCH v6 13/43] drm/vkms: Add KUnit test for device lifecycle

From: Louis Chauvet

Date: Fri Nov 20 2026 - 13:04:29 EST


The configuration objects are now reference-counted and their lifetime is
driven by explicit get/put calls. Add tests aiming to spot UAF and leaks
using KASAN.

Signed-off-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
---
drivers/gpu/drm/vkms/tests/.kunitconfig | 12 ++
drivers/gpu/drm/vkms/tests/Makefile | 3 +-
drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c | 259 +++++++++++++++++++++++
drivers/gpu/drm/vkms/vkms_drv.c | 3 +
4 files changed, 276 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vkms/tests/.kunitconfig b/drivers/gpu/drm/vkms/tests/.kunitconfig
index 6a2d87068edc..b72899f06088 100644
--- a/drivers/gpu/drm/vkms/tests/.kunitconfig
+++ b/drivers/gpu/drm/vkms/tests/.kunitconfig
@@ -2,3 +2,15 @@ CONFIG_KUNIT=y
CONFIG_DRM=y
CONFIG_DRM_VKMS=y
CONFIG_DRM_VKMS_KUNIT_TEST=y
+CONFIG_KASAN=y
+CONFIG_KASAN_INLINE=y
+CONFIG_KASAN_VMALLOC=y
+CONFIG_KUNIT_ALL_TESTS=n
+CONFIG_DEBUG_KMEMLEAK=y
+CONFIG_DEBUG_OBJECTS=y
+CONFIG_DEBUG_OBJECTS_FREE=y
+CONFIG_DEBUG_OBJECTS_TIMERS=y
+CONFIG_DEBUG_SLAB=y
+CONFIG_PAGE_POISONING=y
+CONFIG_PAGE_POISONING_NO_SANITY=n
+CONFIG_PAGE_POISONING_ZERO=y
diff --git a/drivers/gpu/drm/vkms/tests/Makefile b/drivers/gpu/drm/vkms/tests/Makefile
index d4d9ba8d4c54..a7810a12c9c8 100644
--- a/drivers/gpu/drm/vkms/tests/Makefile
+++ b/drivers/gpu/drm/vkms/tests/Makefile
@@ -3,6 +3,7 @@
vkms-kunit-tests-y := \
vkms_config_test.o \
vkms_format_test.o \
- vkms_color_test.o
+ vkms_color_test.o \
+ vkms_lifecycle_test.o \

obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms-kunit-tests.o
diff --git a/drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c b/drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c
new file mode 100644
index 000000000000..b319f6424285
--- /dev/null
+++ b/drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c
@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include <kunit/test.h>
+#include <linux/string.h>
+
+#include "../vkms_config.h"
+#include "../vkms_drv.h"
+
+MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");
+
+#define LIFECYCLE_ITERATIONS 50
+#define STRESS_ITERATIONS 500
+
+static void vkms_lifecycle_test_create_destroy_default(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+ config = vkms_config_default_create(true, true, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_create_destroy_with_overlay(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+ config = vkms_config_default_create(true, true, true, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_create_destroy_with_pipeline(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+ config = vkms_config_default_create(true, true, true, true);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_create_destroy_minimal(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+ config = vkms_config_default_create(false, false, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_create_destroy_writeback(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+ config = vkms_config_default_create(false, true, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_stress_many_cycles(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < STRESS_ITERATIONS; i++) {
+ config = vkms_config_default_create(true, true, true, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_interleaved_create_destroy(struct kunit *test)
+{
+ struct vkms_config *configs[5];
+ const char *new_name;
+ char name[32];
+ int ret, i, j;
+
+ for (j = 0; j < 20; j++) {
+ for (i = 0; i < 5; i++) {
+ configs[i] = vkms_config_default_create(i & 1, i & 2, i & 4, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, configs[i]);
+
+ snprintf(name, sizeof(name), "vkms-interleaved-%d", i);
+ new_name = kstrdup_const(name, GFP_KERNEL);
+ KUNIT_ASSERT_NOT_NULL(test, new_name);
+ kfree_const(configs[i]->dev_name);
+ configs[i]->dev_name = new_name;
+
+ ret = vkms_create(configs[i]);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+ }
+
+ for (i = 4; i >= 0; i--) {
+ vkms_destroy(configs[i]);
+ vkms_config_destroy(configs[i]);
+ }
+ }
+}
+
+static void vkms_lifecycle_test_destroy_uncreated_device(struct kunit *test)
+{
+ struct vkms_config *config;
+
+ config = vkms_config_default_create(true, true, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ KUNIT_ASSERT_NULL(test, config->dev);
+
+ vkms_config_destroy(config);
+}
+
+static void vkms_lifecycle_test_double_destroy(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret;
+
+ config = vkms_config_default_create(true, true, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ KUNIT_ASSERT_NULL(test, config->dev);
+
+ vkms_config_destroy(config);
+}
+
+static void vkms_lifecycle_test_create_after_destroy(struct kunit *test)
+{
+ struct vkms_config *config;
+ int ret, i;
+
+ for (i = 0; i < 20; i++) {
+ config = vkms_config_default_create(true, true, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+
+ ret = vkms_create(config);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+ }
+}
+
+static void vkms_lifecycle_test_connector_ref_outlives_config(struct kunit *test)
+{
+ struct vkms_config_connector *connector_cfg;
+ struct vkms_config *config;
+
+ config = vkms_config_default_create(false, false, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+ KUNIT_ASSERT_FALSE(test, list_empty(&config->connectors));
+
+ connector_cfg = list_first_entry(&config->connectors,
+ struct vkms_config_connector, link);
+
+ /* Simulate the rmdir while DRM hold the device */
+ vkms_config_connector_get(connector_cfg);
+ vkms_config_destroy_connector(connector_cfg);
+ vkms_config_destroy(config);
+
+ /* The connector must survive, detached from the configuration. */
+ KUNIT_EXPECT_EQ(test, kref_read(&connector_cfg->refcnt), 1);
+ KUNIT_EXPECT_TRUE(test, list_empty(&connector_cfg->link));
+
+ /* Last reference: connector and configuration are freed here. */
+ vkms_config_connector_put(connector_cfg);
+}
+
+static void vkms_lifecycle_test_connector_static_drmm_release(struct kunit *test)
+{
+ struct vkms_config *config;
+
+ config = vkms_config_default_create(true, true, false, false);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+ KUNIT_ASSERT_EQ(test, vkms_create(config), 0);
+
+ /* vkms_destroy() runs the drmm action, which frees and detaches the connector. */
+ vkms_destroy(config);
+ vkms_config_destroy(config);
+}
+
+static struct kunit_case vkms_lifecycle_test_cases[] = {
+ KUNIT_CASE(vkms_lifecycle_test_create_destroy_default),
+ KUNIT_CASE(vkms_lifecycle_test_create_destroy_with_overlay),
+ KUNIT_CASE(vkms_lifecycle_test_create_destroy_with_pipeline),
+ KUNIT_CASE(vkms_lifecycle_test_create_destroy_minimal),
+ KUNIT_CASE(vkms_lifecycle_test_create_destroy_writeback),
+ KUNIT_CASE(vkms_lifecycle_test_stress_many_cycles),
+ KUNIT_CASE(vkms_lifecycle_test_interleaved_create_destroy),
+ KUNIT_CASE(vkms_lifecycle_test_destroy_uncreated_device),
+ KUNIT_CASE(vkms_lifecycle_test_double_destroy),
+ KUNIT_CASE(vkms_lifecycle_test_create_after_destroy),
+ KUNIT_CASE(vkms_lifecycle_test_connector_ref_outlives_config),
+ KUNIT_CASE(vkms_lifecycle_test_connector_static_drmm_release),
+ {}
+};
+
+static struct kunit_suite vkms_lifecycle_test_suite = {
+ .name = "vkms-lifecycle",
+ .test_cases = vkms_lifecycle_test_cases,
+};
+
+kunit_test_suite(vkms_lifecycle_test_suite);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit test for VKMS device lifecycle, aiming to catch UAF and memory issues");
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 64c75b038869..a4bc3d02a6cd 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -18,6 +18,7 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_colorop.h>
+#include <kunit/visibility.h>
#include <drm/drm_drv.h>
#include <drm/drm_fbdev_shmem.h>
#include <drm/drm_file.h>
@@ -250,6 +251,7 @@ static int __init vkms_init(void)

return 0;
}
+EXPORT_SYMBOL_IF_KUNIT(vkms_create);

void vkms_destroy(struct vkms_config *config)
{
@@ -269,6 +271,7 @@ void vkms_destroy(struct vkms_config *config)

config->dev = NULL;
}
+EXPORT_SYMBOL_IF_KUNIT(vkms_destroy);

static void __exit vkms_exit(void)
{

--
2.56.0