Re: [PATCH v5 5/8] mm/gup: break out gup_lookup_pte() helper

From: Rik van Riel

Date: Fri Nov 20 2026 - 13:20:41 EST


On Fri, 2026-11-20 at 17:33 +0000, Lorenzo Stoakes (ARM) wrote:
> On Thu, Nov 19, 2026 at 10:04:04PM -0500, Rik van Riel wrote:
>
>
> Right, I think I need to see it in context to judge really :) but
> obviously we
> can't be introducing completely dead code like that, even
> incrementally.

Agreed. That's been cleaned up now.
>
> >
> > >
> > > 'need_no_page_table' isn't a great name either. Maybe is_none or
> > > something?
> > >
> > Maybe pte_is_none?
>
> OK, let's see how that looks in context.
>
> Since you've not replied to the rest of the reviews I will assume
> implicit 'ack,
> will do's or what not on those? ;)

Those are all "will do's", or rather already done
but not posted yet because I'm combing through the
series for other nits like that to address.

--
All Rights Reversed.