Re: [PATCH v5 1/5] iomap: add iomap_dio_end_io() helper
From: Christoph Hellwig
Date: Fri Nov 20 2026 - 13:24:18 EST
On Fri, Nov 20, 2026 at 02:48:09PM +0100, Christian Brauner wrote:
> On Tue, Nov 17, 2026 at 04:48:40PM -0800, Viacheslav Dubeyko wrote:
> > The helper updates i_size without any locking, so it can be used only
> > by file systems that issue all direct writes extending i_size
> > synchronously (IOMAP_DIO_FORCE_WAIT) under inode_lock.
>
> Meh, this should really not be named so it looks like its the default
> completion handler. iomap_dio_end_io() really sounds like it.
Well, it actually should be the default handler as it does the right
thing for simple file systems. In fact I'd prefer to automatically
call it if no ->end_io is set as that would remove a lot of boilerplate.
It would be nice to do that and remove the duplicate version in various
file systems.