Re: [PATCH rtw-next v3 3/5] wifi: rtw88: do not drop stations when collecting them for an iteration
From: Mehmet Fide
Date: Fri Nov 20 2026 - 13:29:24 EST
Hi Luka,
> Thanks for reproducing this. I was looking at 0bdc579dbfc2, which
> already has b719e9bced93 clearing si->vif in rtw_sta_remove().
Right, my test tree was older than that commit, so what I wrote about
rtw_sta_remove() was wrong.
> Could you rebase v4 on rtw-next and keep the si->vif check in
> rtw_collect_sta_iter()? That should cover the case you reproduced.
Yes. On rtw-next 0bdc579dbfc2 with v3, the client was collected with
si->vif NULL and was gone from mac80211 after the held collection in 2
of 3 runs; in the third the watchdog did not collect it in time. With
the check in v4 it was skipped in 3 of 4 runs. In the fourth the
collection came before the client went back to AUTH, and the removal
waited for it.
Mehmet