Re: [PATCH 1/2] iio: imu: inv_icm42600: return -EBUSY for temperature reads when idle

From: Joe LeVeque

Date: Fri Nov 20 2026 - 13:33:31 EST


Hi Andy,

The -EBUSY here is consistent with the existing invalid-data case in
inv_icm42600_temp_read(), which commit dfdc31e7ccf3 (“iio: imu:
inv_icm42600: change invalid data error to -EBUSY”) changed from
-EINVAL to -EBUSY for the same situation (both accel and gyro off).
Patch 1 returns the same error for the stale-data case, so userspace
sees one consistent response.

https://git.kernel.org/torvalds/c/dfdc31e7ccf3

Thanks,
Joe

On Fri, Nov 20, 2026 at 1:33 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Thu, Nov 19, 2026 at 06:08:49PM -0800, Joe LeVeque wrote:
> > The temperature sensor only measures while the accel or gyro is on.
> > With both off, its data register keeps the last measurement, so a
> > temperature read returns stale data. On an ICM-42688-P, a value held at
> > about 52 C was returned while the chip was at about 62 C. The data only
> > reads as invalid before the first measurement after power-up.
> >
> > The temperature is the die temperature, used for accel and gyro
> > compensation, so return -EBUSY when both are off instead of stale data.
>
> Hmm... EBUSY means they are doing something and kinda hints user to come again.
> Would this condition change on its own if user comes again later with the same
> request?
>
> ...
>
> > + /*
> > + * The temperature sensor only measures while the accel or gyro is
> > + * on; with both off, its data register holds a stale value.
> > + */
> > + if (st->conf.gyro.mode == INV_ICM42600_SENSOR_MODE_OFF &&
> > + st->conf.accel.mode == INV_ICM42600_SENSOR_MODE_OFF) {
> > + ret = -EBUSY;
> > + goto exit;
> > + }
>
> I would choose one from the below (they all have their pros and cons)
>
> ESTALE
> something like this, but error message is specific about file handle
>
> EL3HLT
> what is level 3? But we have the only user, and it is outside network
> and it sounds close to this case, but why not EL2HLT? (Also the users
> are outside network.)
>
> ENODATA
> also used a lot, so semantics not so clear, and data is there, but outdated
>
> Depending on the answer to the question at the top of my reply, the error
> codes may be EIO, ENXIO, EPROTO, EAGAIN (but if EAGAIN fits to the flow,
> EBUSY also fits).
>
> --
> With Best Regards,
> Andy Shevchenko
>
>