[RFC PATCH 0/3] fork,arm,x86,fs/resctrl: Fix stale resource group assignment on fork

From: Reinette Chatre

Date: Fri Nov 20 2026 - 13:39:53 EST


Hi Everybody,

Jedrzej reported that a newly created resource group can start out with tasks
in it, before any task has been assigned to it. He created the reproducer in
patch 3 to demonstrate this.

Hitting this needs a fork() to overlap the removal of the resource group the
forking task belongs to. A system that forks heavily while monitor groups are
created and removed around it will eventually do both at once.

Removing a resctrl resource group moves the group's tasks to another group by
walking the task list, and then frees the group's CLOSID and RMID. A task
created while that walk runs escapes it: fork() copies the parent's CLOSID
and RMID early in copy_process(), before the new task is linked onto the task
list, and the walk holds tasklist_lock for read so the new task cannot join
the list until the walk has finished.

The new task is thus left with the CLOSID and RMID of a resource group that no
longer exists, and passes them on to every task it creates.

Once the freed CLOSID and RMID are handed to a resource group created later the
strays appear in that group's tasks file, their memory accesses are counted in
its monitoring data, and they are subject to its allocation policy, while the
group intended for them does not control or monitor them.

Series layout
=============

Patch 1 depicts the race.

resctrl has no fork() hook today. Patch 1 adds one, resctrl_copy_process(),
called from copy_process() while tasklist_lock is held for write, which is the
lock the task list walk is serialized against. Considering klp_copy_process(),
this seems to match the custom used to address an issue with this shape.

1 Add resctrl_copy_process() and assign a task's CLOSID and RMID
with tasklist_lock held
2 Record the new tasklist_lock requirement with lockdep
3 Reproducer, not for inclusion

Why is this an RFC?
===================

- resctrl_copy_process() runs on every fork(), so
resctrl_arch_copy_closid_rmid() is a static inline on x86 but is
out-of-line for MPAM. The note below patch 1 describes what was
attempted to make it inline for MPAM and asks the MPAM maintainers
what shape it should take there.

- Patch 1 touches kernel/fork.c. It adds a single call inside the
existing write_lock_irq(&tasklist_lock) region of copy_process(),
immediately after klp_copy_process() on which it is modelled.

How was this tested?
====================
The issue can be reproduced using Jedrzej's script found in patch #3. On
my test system the issue is encountered on a single run. With these fixes
the reproducer did not encounter the issue in 100 runs.

What remains?
=============
On x86 the CLOSID and RMID are separate values in struct task_struct and
__resctrl_sched_in() reads them without a lock, so a task can still be
labelled with a mismatched pair for the duration of a move. Unlike the
fork case, which is permanent and invisible to every later walk of the
task list, that window is transient and the pair is corrected at the next
context switch. MPAM stores the two as a single value.

The series is based on v7.4-rc3.

Any feedback is appreciated.

Thank you.

Reinette

Jedrzej Wasiukiewicz (1):
NOT_FOR_INCLUSION: selftests/resctrl: Tasks keep using removed RMID
after fork() reproducer

Reinette Chatre (2):
fork,arm,x86,fs/resctrl: Fix stale resource group assignment vs
copy_process()
arm,x86/resctrl: Assert tasklist_lock is held when setting CLOSID and
RMID

arch/arm64/include/asm/mpam.h | 6 +
arch/x86/include/asm/resctrl.h | 11 ++
drivers/resctrl/mpam_resctrl.c | 8 ++
fs/resctrl/rdtgroup.c | 21 +++
include/linux/arm_mpam.h | 1 +
include/linux/resctrl.h | 28 ++++
kernel/fork.c | 3 +
.../selftests/resctrl/stray_tasks_repro.sh | 122 ++++++++++++++++++
8 files changed, 200 insertions(+)
create mode 100755 tools/testing/selftests/resctrl/stray_tasks_repro.sh


base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
--
2.56.0