Re: [PATCH v2] cred: annotate data race on non_rcu when copying a cred

From: Serge E. Hallyn

Date: Fri Nov 20 2026 - 14:33:50 EST


On Sat, Nov 14, 2026 at 05:29:00AM +0000, Babanpreet Singh wrote:
> prepare_creds() copies the current cred while another task can be in
> get_cred() on it, clearing non_rcu. KCSAN reports:
>
> BUG: KCSAN: data-race in io_prep_async_work / prepare_creds
>
> write to 0xffff8881046cea68 of 4 bytes by task 3646 on cpu 1:
> get_cred_many include/linux/cred.h:222 [inline]
> get_cred include/linux/cred.h:238 [inline]
> io_prep_async_work+0x9b/0x3c0 io_uring/io_uring.c:367
>
> read to 0xffff8881046ce9c0 of 184 bytes by task 3645 on cpu 0:
> prepare_creds+0x71/0x550 kernel/cred.c:192
>
> The race is harmless. non_rcu and usage are the only fields that change
> on a published cred, and both are reset on the new cred right after the
> copy.
>
> Annotate the copy with data_race(). prepare_kernel_cred() makes the
> same copy, so annotate it too and switch it to memcpy() to match.
>
> Reported-by: syzbot+ee58b040032d8bed63d9@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=ee58b040032d8bed63d9
> Reported-by: syzbot+557fdc985d6ac3831e14@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=557fdc985d6ac3831e14
> Signed-off-by: Babanpreet Singh <bbnpreetsingh@xxxxxxxxx>

Reviewed-by: Serge Hallyn <serge@xxxxxxxxxx>

At the moment this seems correct.

I do worry that if struct cred changes/evolves, then this solution
may mask newly introduced regressions. But I don't have a better
idea. I mean, I guess we could keep usage at front and nonrcu at
back, and memcpy just the parts in between... In a clearly
named new helper function that wouldn't be so bad, e.g.

static inline void cred_memcpy(new, old), and let cred_mempy do
the offset and size calculation.

> ---
> Drafted with Claude, an LLM coding assistant, from the syzbot reports.
>
> kernel/cred.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cred.c b/kernel/cred.c
> index d01df40a9a386..d9ab1cb4230a8 100644
> --- a/kernel/cred.c
> +++ b/kernel/cred.c
> @@ -189,7 +189,12 @@ struct cred *prepare_creds(void)
> kdebug("prepare_creds() alloc %p", new);
>
> old = task->cred;
> - memcpy(new, old, sizeof(struct cred));
> + /*
> + * Another task can be in get_cred() on the old cred, clearing
> + * non_rcu. That and usage are the only fields that change on a
> + * published cred, and both are set fresh below.
> + */
> + data_race(memcpy(new, old, sizeof(struct cred)));
>
> new->non_rcu = 0;
> atomic_long_set(&new->usage, 1);
> @@ -573,7 +578,8 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon)
>
> old = get_task_cred(daemon);
>
> - *new = *old;
> + /* Same race as in prepare_creds(). */
> + data_race(memcpy(new, old, sizeof(struct cred)));
> new->non_rcu = 0;
> atomic_long_set(&new->usage, 1);
> get_uid(new->user);
>
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> --
> 2.54.0 (Apple Git-157)