Re: [PATCH v4 0/3] staging: media: atomisp: use kvmalloc_objs() and drop redundant OOM messages

From: Rodrigo Gobbi

Date: Fri Nov 20 2026 - 14:40:17 EST


On 7/14/26 19:48, Rodrigo Gobbi wrote:
> Several allocations in the atomisp driver still size their buffers with
> open-coded multiplication, e.g. width * height * sizeof(*p). When the
> dimensions are large the product can silently wrap, causing kvmalloc()
> to allocate an undersized buffer.
>
> Convert the remaining sites to kvmalloc_objs() with array_size(), which
> saturate to SIZE_MAX on overflow so kvmalloc() returns NULL instead of
> allocating too few bytes.
>
> This continues the work started in commit [2], and picks up the stalled
> sites from [1], unifying with [3].
>
> While here, drop the redundant IA_CSS_ERROR("out of memory") messages on
> the touched allocation paths: the memory management core already emits a
> far more detailed warning on allocation failure as raised at [1].
>
> [1] https://lore.kernel.org/all/20260413112904.98864-1-feng@xxxxxxxxx/
> [2] d178c7ca8fef ("staging: media: atomisp: use array3_size() for overflow-safe allocation")
> [3] https://lore.kernel.org/all/20260609215110.118860-1-rodrigo.gobbi.7@xxxxxxxxx/
> ---
> Changelog:
> v4: 0002: use the full commit reference form for d178c7ca8fef (Media CI checkpatch); collect Andy's Reviewed-by;
> v3: https://lore.kernel.org/all/20260623221028.40238-1-rodrigo.gobbi.7@xxxxxxxxx/#t
> v2: https://lore.kernel.org/all/20260622224402.34001-1-rodrigo.gobbi.7@xxxxxxxxx/
> v1: https://lore.kernel.org/all/20260609215110.118860-1-rodrigo.gobbi.7@xxxxxxxxx/
>
>
> Feng Ning (1):
> staging: media: atomisp: use kvmalloc_objs() for overflow-safe
> allocation
>
> Rodrigo Gobbi (2):
> staging: media: atomisp: use kvmalloc_objs() in make_histogram()
> staging: media: atomisp: drop redundant out-of-memory messages
>
> .../media/atomisp/pci/sh_css_metrics.c | 11 +-
> .../media/atomisp/pci/sh_css_param_dvs.c | 5 -
> .../staging/media/atomisp/pci/sh_css_params.c | 101 +++++++-----------
> 3 files changed, 41 insertions(+), 76 deletions(-)
>

Hi all,

Gentle ping on this series. If there is anything else needed from my side,
please let me know.

Thanks,
Rodrigo.