[PATCH v2 0/1] mm/shmem: don't use the memcg of an uncharged folio

From: Chris Mason

Date: Fri Nov 20 2026 - 14:51:13 EST


Hi everyone,

This is relatively niche, but actually new with 7.4-rc1, and I would
expect it to trigger under heavy load with huge=always on tmpfs. We'd
need to run out of room in the tmpfs or reclaim memory while huge folios
are migrated.

Qinyun Tan's pending series fixes the oops:

[PATCH v4 RESEND 2/5] mm: memcontrol: drop kmemcg_id and use
mem_cgroup_id() for list_lru indexing
https://lore.kernel.org/all/20261105092233.3558950-3-qinyuntan@xxxxxxxxxxxxxxxxx/

It makes memcg_list_lru_allocated() accept a NULL memcg, but I think we
can still race and corrupt lists instead:

shmem_unused_huge_requeue() __migrate_folio()
=========================== =================
folio_memcg_list_lru_alloc()
folio_memcg() is NULL
no lists are allocated
mem_cgroup_migrate()
commit_charge(newfolio)
get_obj_cgroup_from_folio()
returns the objcg of memcg M
list_lru_add(M)
if M has no lists, the inode
goes on the parent's list

[ later, M gets lists of its own ]

list_lru_del(M)
locks M's list
unlinks from the parent's list

I haven't tried to reproduce on top of the kmemcg_id series, so that's
all just guessing from the code.

v1->v2: adopt Qi Zheng's suggestion to return early in the failure path

v1: https://lore.kernel.org/all/20261119193656.88678-1-mason@xxxxxxxxxx/

This is on top of v7.4-rc3.

Chris Mason (1):
mm/shmem: don't use the memcg of an uncharged folio

mm/shmem.c | 39 +++++++++++++++++++++++++++++++--------
1 file changed, 31 insertions(+), 8 deletions(-)

--
2.55.0