Re: [PATCH net v2 2/2] ionic: limit TSO segments to the minimum Tx ring size

From: Rao, Nikhil

Date: Fri Nov 20 2026 - 14:59:04 EST


On 11/17/2026 11:18 AM, Nikhil P. Rao wrote:
ionic uses one Tx descriptor per TSO segment, and a Tx ring holds at
most num_descs - 1 of them. The driver does not set tso_max_segs, so
the stack can hand it GSO skbs with more segments than the Tx ring
can hold. ionic_tx() then stops the queue waiting for descriptors
that can never become free, and the netdev watchdog fires repeatedly.

This was hit in production: guest TCP traffic with an MSS below 64
produced 64 KB GSO skbs on the default 1024-entry ring.

Raise the minimum Tx ring size to IONIC_MIN_TX_DESC (128), for the
hwstamp and kdump Tx rings as well, and set tso_max_segs to
IONIC_MIN_TX_DESC - 1 so that every Tx ring can hold the largest TSO
skb. Larger GSO skbs are segmented in software. 127 segments still
covers a 64 KB skb at the 536 byte default MSS.

IONIC_MIN_TXRX_DESC now only applies to Rx, so rename it to
IONIC_MIN_RX_DESC.

Tested on an AMD Pensando NIC with GSO frames of about 1500 segments,
injected through a tap with a virtio-net header and redirected to the
ionic netdev with tc mirred: without this patch the Tx queue stalls and
the watchdog fires, and with it they are sent.

Fixes: 0f3154e6bcb3 ("ionic: Add Tx and Rx handling")
Cc: stable@xxxxxxxxxxxxxxx
Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Link: https://lore.kernel.org/all/20261112082753.6ee90fc8@xxxxxxxxxx/
Signed-off-by: Nikhil P. Rao <nikhil.rao@xxxxxxx>
Reviewed-by: Brett Creeley <brett.creeley@xxxxxxx>
---
drivers/net/ethernet/pensando/ionic/ionic_dev.h | 3 ++-
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 4 ++--
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 10 ++++++----
3 files changed, 10 insertions(+), 7 deletions(-)

[...]
A note for the stable backport: on kernels before v6.19 this patch alone
does not stop the stall for guest traffic. A guest's GSO skb arrives as
SKB_GSO_DODGY with gso_segs still 0, so gso_features_check() never sees
it exceed gso_max_segs. That is the production case here: guest TCP
forwarded through the host to an ionic VF. be1b70ab21cb ("net: init
shinfo->gso_segs from qdisc_pkt_len_init()") fills in gso_segs before
that check.

Tested on v6.8 with an AMD Pensando NIC, using the same tap + tc mirred
injection: with this series alone the Tx queue still stalls; with
be1b70ab21cb added (a one-line backport there) the frames are sent.

So the stable tag on this patch should have been:

Cc: stable@xxxxxxxxxxxxxxx # 6.18.x and older: be1b70ab21cb: net: init shinfo->gso_segs from qdisc_pkt_len_init()