Re: [PATCH net 2/4] net: bcmgenet: restart DIM from the default profile on ring init
From: Nicolai Buchwitz
Date: Fri Nov 20 2026 - 15:17:15 EST
On 19.11.2026 21:31, netdev-bot+sashiko@xxxxxxxxxx wrote:
[...]
[Severity: High]
Can the same stuck DIM state still happen through Wake-on-LAN
suspend/resume?
The reset only runs from bcmgenet_init_dim(). Its only caller is
bcmgenet_init_rx_ring(), which is reached through bcmgenet_init_dma().
The WoL branch of bcmgenet_suspend() goes through the same cancel that
the commit message describes for close:
bcmgenet_suspend()
if (device_may_wakeup(d) && priv->wolopts) {
...
bcmgenet_disable_rx_napi(priv);
disable_irq(priv->irq1);
...
}
bcmgenet_disable_rx_napi()
napi_disable(&ring->napi);
cancel_work_sync(&ring->dim.dim.work);
Suppose the last net_dim() call set dim->state = DIM_APPLY_NEW_PROFILE
and scheduled the work just before this point. The work is cancelled,
and bcmgenet_dim_work() never runs. It is the only place that moves the
state back to DIM_START_MEASURE.
On resume, the fast path in bcmgenet_resume() re-enables RX NAPI without
reinitializing the rings:
bcmgenet_resume()
if (priv->tx_cbs && (reg & CMD_RX_EN)) {
/* Successfully exited WoL, just resume data flows */
...
bcmgenet_enable_rx_napi(priv);
That means bcmgenet_init_dim() is not called, so the new memset and
profile_ix reset never run. After that, every net_dim() call hits:
case DIM_APPLY_NEW_PROFILE:
break;
Adaptive RX coalescing stays frozen until the next ifdown/ifup. Also,
profile_ix already points at the new profile, while the
DMA_MBUF_DONE_THRESH and DMA_RING0_TIMEOUT registers still hold the old
values.
Toggling adaptive coalescing through ethtool doesn't seem to recover
from this, since bcmgenet_set_ring_rx_coalesce() never touches
dim.state.
Would it work better to reset ring->dim.dim.state, and re-sync
profile_ix, in bcmgenet_disable_rx_napi() right after
cancel_work_sync()? That would cover both close and WoL suspend.
The later patches in this series ("net: bcmgenet: reset the Rx discard
count with the ring" and "net: systemport: accumulate the DIM packet and
byte counters") don't touch this path, so the gap is still there at the
end of the series.
dim->event_ctr = 0;
dim->packets = 0;
dim->bytes = 0;
Valid point. I will use flush_work() instead, which is IMHO a better fit.
It applies the pending profile, so profile_ix and the hardware stay in
sync, and it covers both close and WoL suspend.
--
pw-bot: cr