Re: [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header
From: Nicolas Schier
Date: Fri Nov 20 2026 - 15:21:37 EST
On Fri, Nov 20, 2026 at 12:25:48PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Nov 19, 2026 at 12:47:38PM -0700, Nathan Chancellor wrote:
> > On Thu, Nov 19, 2026 at 04:24:47PM +0100, Nicolas Schier wrote:
> > > So my questions:
> > >
> > > * Shall we keep it the way it is to keep the original patch order
> > > (bisect might fail on the two commits before this patch)?
> > >
> > > * Or shall the patch be moved before Uwe's (removing the 'Fixes' tag,
> > > and rewriting the commit msg)?
> > >
> > > I am in favor of the latter. Are there any objections?
> > >
> > >
> > > [1]: https://git.kernel.org/kbuild/c/f1dc66c38b7eb4b2fb946a2fd6929250ecd2d85a
> > > [2]: https://patch.msgid.link/bc9fbf5784f6788e10c749a05d56c42bdb68f3d9.1792144769.git.u.kleine-koenig@xxxxxxxxxxxx
> >
> > If history is already being rewritten, I believe it is always good to
> > fix potential bisection issues like this. Rewriting the commit message
> > (and maybe some of the diff?) and placing it in an order such that the
> > build cannot break sounds great to me (but others are free to disagree).
>
> Full ack. I think the danger to hit that point during bisection is
> small, but I like the 2nd option as this reduces the small chance to 0
> in that case that people yell at me :-)
>
> So from my side: go!
Thanks!
I'll send a patch that combines both patches in a few minutes. I plan
to replace
* Move struct cpu_feature to <linux/cpufeature.h>
https://patch.msgid.link/bc9fbf5784f6788e10c749a05d56c42bdb68f3d9.1792144769.git.u.kleine-koenig@xxxxxxxxxxxx
and
* devicetable-offsets: Get struct cpu_feature from a device-id header
https://patch.msgid.link/f610c07f39df15f3e7ebdc63bfcd759ca7a687a8.1794233316.git.sashal@xxxxxxxxxx
with it. Please complain in case of objections or inappropriate tags.
Have a nice weekend!
--
Nicolas