Re: [PATCH net v10 1/4] net: hsr: keep GRO disabled on HSR/PRP ports
From: Xin Xie
Date: Fri Nov 20 2026 - 16:28:18 EST
On 20/11/2026 03:22, netdev-bot+sashiko@xxxxxxxxxx wrote:
> So the SET reply says GRO is wanted but not active. A later
> ETHTOOL_MSG_FEATURES_GET then reads dev->wanted_features in
> features_prepare_data() and shows GRO as not wanted.
This is intended, and the commit message says so: a GRO request on a
member is dropped, not kept pending. While GRO stays off,
ETHTOOL_SFEATURES returns no ETHTOOL_F_WISH and the netlink SET reply
shows the bit as not applied. A later GET reads the stored request,
which no longer has GRO; a SET reply and a GET can already differ in
the same way for a bit outside hw_features.
> Could the request stay in wanted_features, with only the computed
> features masked here?
Masking only the computed features is what v7 did, and it breaks veth,
which adds and deletes its NAPI instances according to wanted_features;
the commit message names the two failures. Changing veth is a separate
matter and not part of this fix.
--
Xin