Re: [PATCH net v10 2/4] net: hsr: refuse forwarding devices as HSR/PRP ports

From: Xin Xie

Date: Fri Nov 20 2026 - 16:30:55 EST


On 20/11/2026 03:22, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Can a plain veth slave still re-enter the xmit path of its own HSR master?

Yes. The redirect case exists without the patch, and the commit message
lists it as not covered. seqnr_lock has been held across the port
transmit since 06afd2c31d33 and 430d67bdcb04. The patch refuses port
types that make no sense as HSR/PRP ports, which covers the syzbot
topology, as Sebastian suggested [1].

> Would it be
> better to stop holding seqnr_lock across dev_queue_xmit() in this fix,
> instead of adding a denylist that the planned lock narrowing would
> replace?

Releasing seqnr_lock before the port transmit closes the whole class,
but it can reorder frames for receivers without aae9d6b616b5 ("hsr:
Implement more robust duplicate discard for HSR"). It is left to
net-next, where Hangbin's patch [2] fits.

> Could this hunk move into the GRO policy patch, or could a stable
> dependency note be added?

No stable backport is requested for this series. The macvlan GRO check
depends on patch 1 and makes no sense in a tree without it.

[1] https://lore.kernel.org/netdev/20261014151838.6RyMIRVM@xxxxxxxxxxxxx/
[2] https://lore.kernel.org/netdev/20260805-hsr_deadlock-v1-1-d8a6f06fc5a8@xxxxxxxxxx/

--
Xin