Re: [PATCH bpf-next v3 4/8] libbpf: ringbuf: Add a caller-owned iterator
From: bot+bpf-ci
Date: Fri Nov 20 2026 - 16:34:55 EST
> libbpf: ringbuf: Add a caller-owned iterator
TL;DR: The new ring_buffer_iter_new/next/destroy exports in libbpf.map may not
follow libbpf's double-underscore naming convention; they become ABI once
released, so should they be renamed?
> diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
> --- a/tools/lib/bpf/libbpf.map
> +++ b/tools/lib/bpf/libbpf.map
[ ... ]
> @@ -479,4 +479,7 @@ LIBBPF_1.9.0 {
> bpf_program__load;
> bpf_program__load_strategy;
> bpf_program__set_load_strategy;
> + ring_buffer_iter_destroy;
> + ring_buffer_iter_new;
> + ring_buffer_iter_next;
> } LIBBPF_1.8.0;
Should these three names follow the libbpf naming convention for object
methods?
Documentation/bpf/libbpf/libbpf_naming_convention.rst says functions that
work with an object are built from the object name, a double underscore and
a part describing the purpose, as in bpf_object__open and ring_buffer__new.
The other ring buffer exports all use the separator:
ring_buffer__new, ring_buffer__poll, ring_buffer__consume,
ring_buffer__consume_n, ring_buffer__ring
ring__consume, ring__consume_n, ring__consumer_pos, ring__producer_pos,
ring__avail_data_size, ring__size, ring__map_fd
user_ring_buffer__new, user_ring_buffer__reserve, user_ring_buffer__submit
ring_buffer_iter_new(), ring_buffer_iter_next() and ring_buffer_iter_destroy()
look like the only ring buffer symbols without it, and the iterator is
created from a struct ring * while the existing per-ring operations use the
ring__ prefix.
Once a libbpf release ships these names in libbpf.map they become ABI.
Would ring_buffer_iter__new()/__next()/__destroy() or ring__iter_*() be a
better fit?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44815895103