Re: [syzbot] [media?] KASAN: use-after-free Read in media_request_release
From: syzbot
Date: Fri Nov 20 2026 - 17:12:25 EST
> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
Patch testing via #syz test is temporarily disabled.
See https://github.com/google/syzkaller/issues/8122 for details.
>
> Proposed fix, two patches combined below:
> 1. media: mc: request: don't touch mdev after req_free()
> 2. media: vivid: hold a v4l2_device reference for each request
>
> vivid's req_alloc()/req_free() take and drop a v4l2_device reference,
> so the vivid_dev can't be freed while a request still points at its
> media_device. The core change moves the num_requests decrement before
> req_free(), since req_free() may now drop the last reference.
>
> ---
> diff --git a/drivers/media/mc/mc-request.c b/drivers/media/mc/mc-request.c
> index e1387f03978..96872de536e 100644
> --- a/drivers/media/mc/mc-request.c
> +++ b/drivers/media/mc/mc-request.c
> @@ -71,11 +71,11 @@ static void media_request_release(struct kref *kref)
>
> media_request_clean(req);
>
> + atomic_dec(&mdev->num_requests);
> if (mdev->ops->req_free)
> mdev->ops->req_free(req);
> else
> kfree(req);
> - atomic_dec(&mdev->num_requests);
> }
>
> void media_request_put(struct media_request *req)
> diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c
> index c042d92db17..24b77ea602a 100644
> --- a/drivers/media/test-drivers/vivid/vivid-core.c
> +++ b/drivers/media/test-drivers/vivid/vivid-core.c
> @@ -881,9 +881,31 @@ static int vivid_req_validate(struct media_request *req)
> return vb2_request_validate(req);
> }
>
> +static struct media_request *vivid_req_alloc(struct media_device *mdev)
> +{
> + struct vivid_dev *dev = container_of(mdev, struct vivid_dev, mdev);
> + struct media_request *req;
> +
> + req = kzalloc_obj(*req);
> + if (!req)
> + return NULL;
> + v4l2_device_get(&dev->v4l2_dev);
> + return req;
> +}
> +
> +static void vivid_req_free(struct media_request *req)
> +{
> + struct vivid_dev *dev = container_of(req->mdev, struct vivid_dev, mdev);
> +
> + v4l2_device_put(&dev->v4l2_dev);
> + kfree(req);
> +}
> +
> static const struct media_device_ops vivid_media_ops = {
> .req_validate = vivid_req_validate,
> .req_queue = vb2_request_queue,
> + .req_alloc = vivid_req_alloc,
> + .req_free = vivid_req_free,
> };
> #endif
>