[PATCH v2 1/7] media: rkvdec: hevc: apply request controls first
From: Daniel Golle
Date: Fri Nov 20 2026 - 18:41:59 EST
The HEVC run preamble looks up the control values before the request is
applied. Applying a request can reallocate the array of a dynamic array
control, so the pointers taken before may point to freed memory. The
slice count and the information whether the RPS controls were set are
also those of the previous request.
Userspace can trigger the reallocation by passing more elements of such
a control than in any earlier request.
Apply the request first and look up the controls afterwards, as the VP9
code does.
Fixes: 3595375c2301 ("media: rkvdec: Add HEVC backend")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
---
Changes since v1:
- Rewrite the commit message
- No code change
drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.c b/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.c
index 2b8e04dd15727..c249e3f16f42c 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-common.c
@@ -429,6 +429,8 @@ void rkvdec_hevc_run_preamble(struct rkvdec_ctx *ctx,
{
struct v4l2_ctrl *ctrl;
+ rkvdec_run_preamble(ctx, &run->base);
+
ctrl = v4l2_ctrl_find(&ctx->ctrl_hdl,
V4L2_CID_STATELESS_HEVC_DECODE_PARAMS);
run->decode_params = ctrl ? ctrl->p_cur.p : NULL;
@@ -460,6 +462,4 @@ void rkvdec_hevc_run_preamble(struct rkvdec_ctx *ctx,
} else {
run->ext_sps_lt_rps = NULL;
}
-
- rkvdec_run_preamble(ctx, &run->base);
}
--
2.56.1