Re: [PATCH v2 2/2] Input: synaptics_tcm_i2c - add Synaptics TouchComm I2C touchscreen driver

From: Majid Hajiheidari

Date: Fri Nov 20 2026 - 18:57:31 EST


Hi Vsevolod,

On Thu, 10 Sep 2026 16:14:05 +0700, Vsevolod Nevorotov wrote:
> Add input touchscreen driver for Synaptics TouchComm (TCM) generation-1
> controllers connected over I2C that boot into application mode out of
> their own flash (such as the Synaptics S3908 fitted to the OnePlus 9RT).

I tested v2 on a OnePlus 11 (SM8550), which has the same S3908, on top of
next-20261120 with an out-of-tree device tree.

synaptics-tcm-i2c 1-004b: TouchComm v1, mode 0x01, part s3908-15.0.0
synaptics-tcm-i2c 1-004b: 5760x12864, 10 touch objects

Touch works under Phosh, including multi-touch. With wakeup-source set,
the double-tap gesture is reported (KEY_WAKEUP) while the device is
suspended, and touch works again after resume. I could only exercise this
with /sys/power/pm_test = devices, because a full system suspend does not
work on this platform yet.

One question on patch 1/2: the binding describes vdd as the core/digital
supply and avdd as the analog one, but its example connects vdd to a 3.0 V
and avdd to a 1.8 V regulator. Which is intended?

Tested-by: Majid Hajiheidari <majidhhdri@xxxxxxxxx> # OnePlus 11

Thanks,
Majid