Re: [PATCH] block/t10-pi: deduplicate blk_reftag_remap_{prepare,complete}()
From: Christoph Hellwig
Date: Fri Nov 20 2026 - 19:18:32 EST
On Fri, Nov 20, 2026 at 10:29:18AM -0800, Caleb Sander Mateos wrote:
> Sure, happy to switch to an if statement instead of the ternaries to
> initialize from and to. However, the code generation is worse with the
> 2 calls to blk_reftag_remap()/blk_tuple_remap(). The compiler doesn't
> notice that the calls are identical except for the swapped arguments
> and emits 2 out-of-line calls to the function instead of inlining it.
Add a __force_inline tag to blk_tuple_remap and see if that fixes it?