Re: [PATCH] ksmbd: check the ACEs after an NFS mode ACE in a DACL
From: Namjae Jeon
Date: Fri Nov 20 2026 - 19:30:02 EST
On Sat, Nov 21, 2026 at 1:34 AM Ian Bridges <icb@xxxxxxxxxxxx> wrote:
>
> An allow ACE with SID S-1-5-88-3-<mode> supplies the POSIX mode
> directly, and parse_dacl() stops walking the ACEs at the first one.
> The same walk checks each ACE and maps its generic rights, so the ACEs
> after the NFS mode ACE are neither checked nor mapped. set_info_sec()
> still stores the entire DACL and the request succeeds, but part of
> that DACL can have no effect.
>
> Continue checking the remaining ACEs and mapping their generic rights,
> while preserving the mode from the first NFS mode ACE.
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ian Bridges <icb@xxxxxxxxxxxx>
Applied it to #ksmbd-for-next.
Thanks!