Re: [PATCH net-next v12 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D
From: Mieczyslaw Nalewaj
Date: Fri Nov 20 2026 - 20:30:58 EST
On 20/11/2026 Gustavo Foletto Mora wrote:
> - Live vlan_filtering toggle on a bridge with a VLAN in use: IVL/SVL
> changes at once in both directions. [...] Each toggle that flips the
> switch-wide state took 20 to 30 ms.
> - The rollback added in v12 is an error path I could not provoke here.
>
> The rest of the series passes my regression test on this board as with
> v11: [...]
>
> Tested-by: Gustavo Foletto Mora <gusfmora@xxxxxxxxx>
Hi Gustavo,
Thank you for testing again, and for the timings.
In v13 I changed one thing in this patch after the automated review
(Sashiko) of v12: an entry that loses its last member could stay in
hardware with IVL_EN=1. rtl8365mb_vlan_4k_port_set() cleared its bit
in vlan_4k_used, so rtl8365mb_d_vlan_4k_refresh_ivl() never visited it
again, and after filtering was switched off, frames with that VID
would still have been looked up with IVL instead of SVL (FID 0).
On family D the emptied entry is now written back with IVL_EN cleared,
as in its reset state:
vlan4k.ivl_en = vlan4k.member &&
rtl8365mb_d_want_ivl(ds, -1, false);
The commit message and the comment in the code say so. Family C is
unchanged.
This path is only reached when the last port leaves a VLAN while
filtering is on (e.g. a port leaving a VLAN-aware bridge), which the
toggle test does not exercise, so I kept your Tested-by but would be
glad if you could re-run that case.
Best regards,
Mieczyslaw