[PATCH v10 07/16] perf tests: Exercise the x86 operand parser
From: Arnaldo Carvalho de Melo
Date: Fri Nov 20 2026 - 22:21:37 EST
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Add a unit test for the x86 operand parser covering the absolute
addressing and movabs forms the data type resolver handles. The cases
are the instructions from the allmodconfig clang build quoted in the two
fixes.
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
tools/perf/tests/Build | 1 +
tools/perf/tests/annotate-ops.c | 127 ++++++++++++++++++++++++++++++++
tools/perf/tests/builtin-test.c | 1 +
tools/perf/tests/tests.h | 1 +
4 files changed, 130 insertions(+)
create mode 100644 tools/perf/tests/annotate-ops.c
diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
index 5eebb2ec5ddefcfd..c7edd8569bbccb06 100644
--- a/tools/perf/tests/Build
+++ b/tools/perf/tests/Build
@@ -2,6 +2,7 @@
perf-test-y += builtin-test.o
perf-test-y += tests-scripts.o
+perf-test-y += annotate-ops.o
perf-test-y += parse-events.o
perf-test-y += uncore-event-sorting.o
perf-test-y += dso-data.o
diff --git a/tools/perf/tests/annotate-ops.c b/tools/perf/tests/annotate-ops.c
new file mode 100644
index 0000000000000000..1c73433fbac67d85
--- /dev/null
+++ b/tools/perf/tests/annotate-ops.c
@@ -0,0 +1,127 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The x86 operand parser: what is a memory reference and where it points.
+ *
+ * The absolute addressing forms are the ones perf annotate's data type
+ * resolver has to follow, and the ones it must not mistake for a data
+ * access: a direct branch target and an immediate.
+ */
+#include <elf.h>
+#include <linux/compiler.h>
+#include <stdlib.h>
+#include <string.h>
+#include "annotate.h"
+#include "debug.h"
+#include "disasm.h"
+#include "tests.h"
+
+struct op_case {
+ const char *insn;
+ const struct ins_ops *ops;
+ const char *operand;
+ enum annotated_insn_ops which;
+ bool mem_ref;
+ int offset;
+};
+
+static struct op_case op_cases[] = {
+ /* 32-bit absolute, and the 64-bit sign extended disp32 both ways */
+ { "mov", &mov_ops, "0x8c73448", INSN_OP_SOURCE, true, 0x8c73448 },
+ { "mov", &mov_ops, "0xffffffffff5fc300", INSN_OP_SOURCE, true, -0xa03d00 },
+ { "mov", &mov_ops, "-0xa03d00", INSN_OP_SOURCE, true, -0xa03d00 },
+ /* An immediate and a direct branch target, with the same 0x */
+ { "mov", &mov_ops, "$0x10", INSN_OP_SOURCE, false, 0 },
+ { "call", &call_ops, "0x401020", INSN_OP_TARGET, false, 0 },
+ { "jmp", &jump_ops, "0x401020", INSN_OP_TARGET, false, 0 },
+ { "loop", NULL, "0x401020", INSN_OP_TARGET, false, 0 },
+};
+
+static int check_operand(const struct arch *arch, const struct op_case *c)
+{
+ struct disasm_line dl = {
+ .ins = { .name = c->insn, .ops = c->ops },
+ };
+ struct annotated_insn_loc loc;
+ struct annotated_op_loc *op;
+ int ret = 0;
+
+ if (c->which == INSN_OP_TARGET)
+ dl.ops.target.raw = (char *)c->operand;
+ else
+ dl.ops.source.raw = (char *)c->operand;
+
+ if (annotate_get_insn_location(arch, &dl, &loc) < 0)
+ return TEST_FAIL;
+
+ op = &loc.ops[c->which];
+ if (op->mem_ref != c->mem_ref) {
+ pr_debug("'%s %s': mem_ref %d, expected %d\n", c->insn,
+ c->operand, op->mem_ref, c->mem_ref);
+ ret = TEST_FAIL;
+ }
+ if (op->mem_ref && op->offset != c->offset) {
+ pr_debug("'%s %s': offset %#x, expected %#x\n", c->insn,
+ c->operand, op->offset, c->offset);
+ ret = TEST_FAIL;
+ }
+
+ return ret;
+}
+
+/* Real disassembly of a movabs, through the instruction's own parser */
+static const char *movabs_lines[][2] = {
+ { "movabsq", "$-0x2000040000000000, %r15 # imm = 0xDFFFFC0000000000" },
+ { "movabs", "$0xdfffffc000000000,%r15" },
+};
+
+static int check_movabs(const struct arch *arch, const char *name, const char *ops)
+{
+ struct disasm_line dl = { .ins = { .name = name } };
+ struct annotated_insn_loc loc;
+ int ret = TEST_FAIL;
+
+ dl.ops.raw = strdup(ops);
+ if (dl.ops.raw == NULL)
+ return TEST_FAIL;
+
+ dl.ins.ops = ins__find(arch, name, &dl);
+ if (dl.ins.ops != &mov_ops || dl.ins.ops->parse(arch, &dl.ops, NULL, &dl) < 0) {
+ pr_debug("'%s %s': not parsed as a mov\n", name, ops);
+ goto out;
+ }
+
+ if (annotate_get_insn_location(arch, &dl, &loc) == 0 &&
+ !loc.ops[INSN_OP_SOURCE].mem_ref && loc.ops[INSN_OP_SOURCE].imm &&
+ loc.ops[INSN_OP_TARGET].reg1 != -1)
+ ret = TEST_OK;
+ else
+ pr_debug("'%s %s': not an immediate to a register\n", name, ops);
+out:
+ free(dl.ops.source.raw);
+ free(dl.ops.target.raw);
+ free(dl.ops.raw);
+ return ret;
+}
+
+static int test__annotate_ops(struct test_suite *test __maybe_unused,
+ int subtest __maybe_unused)
+{
+ struct e_machine_and_e_flags id = { .e_machine = EM_X86_64, };
+ const struct arch *arch = arch__new_x86(&id, NULL);
+ size_t i;
+ int ret = 0;
+
+ if (arch == NULL)
+ return TEST_FAIL;
+
+ for (i = 0; i < ARRAY_SIZE(op_cases); i++)
+ ret |= check_operand(arch, &op_cases[i]);
+
+ for (i = 0; i < ARRAY_SIZE(movabs_lines); i++)
+ ret |= check_movabs(arch, movabs_lines[i][0], movabs_lines[i][1]);
+
+ free((void *)arch);
+ return ret;
+}
+
+DEFINE_SUITE("Annotate operand parsing", annotate_ops);
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 01c78ef20b97dec9..a27baf3a819ccf36 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -117,6 +117,7 @@ static struct test_suite *generic_tests[] = {
&suite__openat_syscall_event_on_all_cpus,
&suite__basic_mmap,
&suite__mem,
+ &suite__annotate_ops,
&suite__parse_events,
&suite__uncore_event_sorting,
&suite__expr,
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index af822885890dda73..963cb34acd345153 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -153,6 +153,7 @@ DECLARE_SUITE(sample_parsing);
DECLARE_SUITE(keep_tracking);
DECLARE_SUITE(parse_no_sample_id_all);
DECLARE_SUITE(dwarf_unwind);
+DECLARE_SUITE(annotate_ops);
DECLARE_SUITE(expr);
DECLARE_SUITE(hists_filter);
DECLARE_SUITE(mmap_thread_lookup);
--
2.56.0