Re: [PATCH v2] md: fix stop_sync_thread() hang on new sync in idle path

From: yu kuai

Date: Fri Nov 20 2026 - 23:00:43 EST


在 2026/11/13 9:09, Li Youhong 写道:

> From: Li Youhong<liyouhong@xxxxxxxxxx>
>
> stop_sync_thread() waits for either MD_RECOVERY_RUNNING to be cleared,
> or (when MD_RECOVERY_FROZEN is clear) for mddev->sync_seq to change.
> The sync_seq counter is only incremented when a sync thread is reaped
> in md_reap_sync_thread(), not on the md_start_sync() not_running path.
>
> If the previous sync attempt took the not_running path, sync_seq does
> not advance. If mddev->thread then queues and runs a new sync in the
> window between flush_work() and wait_event(), that new sync may start
> a real sync thread, leaving MD_RECOVERY_RUNNING set while sync_seq is
> still unchanged. md_idle_sync_thread() then waits until that new sync
> thread is reaped and sync_seq finally changes, even though it only
> needs to wait for the current sync attempt to finish.
>
> Fix this by incrementing sync_seq on the not_running path as well, so
> that the wait condition correctly observes the current sync attempt has
> completed.
>
> Fixes: f52f5c71f3d4 ("md: fix stopping sync thread")
> Cc:stable@xxxxxxxxxxxxxxx
> Signed-off-by: Li Youhong<liyouhong@xxxxxxxxxx>
> ---
> v2:
> - Fix the Fixes: tag to reference the upstream commit f52f5c71f3d4
> instead of the stable backport a17d1bca5aba.
> - v1:https://lore.kernel.org/all/20261112092634.1700963-1-dayou5941@xxxxxxx/
>
> drivers/md/md.c | 1 +
> 1 file changed, 1 insertion(+)
Applied

--
Thanks,
Kuai