Re: [PATCH v7 5/8] gpiolib: cdev: don't leak the IRQ name when the chip is removed

From: Kent Gibson

Date: Fri Nov 20 2026 - 23:52:43 EST


On Fri, Nov 20, 2026 at 10:13:57AM +0200, Adrian Ambrozewicz wrote:
> The character device requests line IRQs with a copy of the consumer
> label as the name, and frees the name that free_irq() returns. When
> gpiochip_remove() frees the IRQ first, it drops that name and the copy
> leaks:
>
> unreferenced object (size 8):
> comm "gpio-hold"
> backtrace (crc dc8eac94):
> kstrdup
> kstrdup_and_replace
> edge_detector_setup
> linereq_create
> gpio_ioctl
>
> Keep the name with the line or v1 line event, and free it there,
> whoever freed the IRQ.
>
> Reproduced with gpio-sim: remove the chip under an open request with
> edge detection and a consumer label. kmemleak reports up to 23 such
> objects after 30 cycles; with this change, none after 100.
>
> Fixes: ec8b6f55b981 ("gpio: free irqs that are still requested when the chip is being removed")
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@xxxxxxxxxx>
> ---
> drivers/gpio/gpiolib-cdev.c | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index f2da4f2646bc..fdcd315e776b 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -400,6 +400,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
> * @desc: the GPIO descriptor for this line.
> * @req: the corresponding line request
> * @irq: the interrupt triggered in response to events on this GPIO
> + * @irq_label: the name @irq was requested with
> * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
> * GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
> * @timestamp_ns: cache for the timestamp storing it between hardirq and
> @@ -423,6 +424,7 @@ struct line {
> */
> struct linereq *req;
> unsigned int irq;
> + char *irq_label;
> /*
> * The flags for the active edge detector configuration.
> *
> @@ -602,16 +604,18 @@ static inline void free_irq_label(const char *label)
> /*
> * gpiochip_remove() frees the interrupts still requested on the lines of the
> * chip being removed, so once the chip is going away the IRQ may no longer be
> - * ours to free.
> + * ours to free. The label is kept by the caller as free_irq() is then not the
> + * one returning it.
> */
> -static void free_line_irq(unsigned int irq, void *dev_id)
> +static void free_line_irq(unsigned int irq, void *dev_id, char **label)
> {
> - const char *name = NULL;
> + const char *name = *label;
>
> if (irq && irq_has_action(irq))
> - name = free_irq(irq, dev_id);
> + free_irq(irq, dev_id);
>
> free_irq_label(name);
> + *label = NULL;
> }
>

The function you are modifying was added in patch 3, so note that this patch is
dependent on patch 3 in the description[1].

> #ifdef CONFIG_HTE
> @@ -939,6 +943,7 @@ static int debounce_setup(struct line *line, unsigned int debounce_period_us)
> return ret;
> }
> line->irq = irq;
> + line->irq_label = label;
> } else {
> ret = hte_edge_setup(line, GPIO_V2_LINE_FLAG_EDGE_BOTH);
> if (ret)
> @@ -981,7 +986,7 @@ static u32 gpio_v2_line_config_debounce_period(struct gpio_v2_line_config *lc,
>
> static void edge_detector_stop(struct line *line)
> {
> - free_line_irq(line->irq, line);
> + free_line_irq(line->irq, line, &line->irq_label);
> line->irq = 0;
>
Similarly - but you only need to note the dependency once.

Cheers,
Kent.
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes