Re: [PATCH v1 01/10] staging: media: tegra-video: Move driver to media/platform/nvidia

From: Svyatoslav Ryhel

Date: Sat Nov 21 2026 - 01:03:49 EST


пт, 20 лист. 2026 р. о 23:31 Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> пише:
>
> On Fri, Nov 20, 2026 at 05:31:17PM +0200, Svyatoslav Ryhel wrote:
> > пт, 20 лист. 2026 р. о 16:31 Laurent Pinchart пише:
> > > On Fri, Nov 13, 2026 at 06:18:10PM +0200, Svyatoslav Ryhel wrote:
> > > > The Tegra Video Input drivers are mature and developed enough to be moved
> > > > from staging into the media subsystem. No other changes are introduced.
> > >
> > > The driver should at least be converted to be MC-centric before being
> > > moved out of staging. I haven't checked if other changes would also be
> > > needed.
> >
> > Does the media subsystem deny video-centric devices from even being
> > moved into it? I have not seen this restriction imposed; could you
> > please point me to where this is stated in the media subsystem
> > documentation?
>
> There's a consensus that devices that require control of camera sensors
> (i.e. "MIPI" cameras) must be MC-centric. That's not documented, we
> should probably fix that.
>

Yeah, stating this in documentation would simplify things.

> > I would like to convert this device, but that may take quite some time
> > and may case regressions if not done carefully. This patchset apart
> > from moving to media is mostly fixes to work correctly with mt9m114
> > and tegra114 bring-up which is quite simple and straight forward
> > change.
>
> Converting to the MC API will require some changes in userspace. That's
> why it's important to make this change before destaging the driver.
>

Noted, I will most likely drop destaging for now then.

> > BTW, may you ack mt9m114 get_fwnode_pad change[1]. I have updated it
> > to your liking, Sakari seems to ignore it.
> >
> > [1] - https://lore.kernel.org/lkml/20261006153619.304520-1-clamor95@xxxxxxxxx/
>
> In the review of v1, I wrote in my last message
> (https://lore.kernel.org/linux-media/20260721103845.GJ50424@xxxxxxxxxxxxxxxxxxxxxxxxxx/)
> that the issue seems to come from a bug in the VI driver. Let's continue
> the discussion there.
>
> > > > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > > > ---
> > > > drivers/media/platform/nvidia/Kconfig | 2 ++
> > > > drivers/media/platform/nvidia/Makefile | 1 +
> > > > .../media => media/platform/nvidia}/tegra-video/Kconfig | 0
> > > > .../media => media/platform/nvidia}/tegra-video/Makefile | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/TODO | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/csi.c | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/csi.h | 0
> > > > .../media => media/platform/nvidia}/tegra-video/tegra20.c | 0
> > > > .../media => media/platform/nvidia}/tegra-video/tegra210.c | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/vi.c | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/vi.h | 0
> > > > .../media => media/platform/nvidia}/tegra-video/video.c | 0
> > > > .../media => media/platform/nvidia}/tegra-video/video.h | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/vip.c | 0
> > > > .../{staging/media => media/platform/nvidia}/tegra-video/vip.h | 0
> > > > drivers/staging/media/Kconfig | 2 --
> > > > drivers/staging/media/Makefile | 1 -
> > > > 17 files changed, 3 insertions(+), 3 deletions(-)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/Kconfig (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/Makefile (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/TODO (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/csi.c (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/csi.h (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/tegra20.c (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/tegra210.c (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vi.c (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vi.h (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/video.c (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/video.h (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vip.c (100%)
> > > > rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vip.h (100%)
> > >
> > > --
> > > Regards,
> > >
> > > Laurent Pinchart
>
> --
> Regards,
>
> Laurent Pinchart