Re: [PATCH net v5 2/5] net: qualcomm: rmnet: Size the first device from the requested data format

From: netdev-bot+sashiko

Date: Sat Nov 21 2026 - 02:04:14 EST


Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message understates what the patch changes.

--

net: qualcomm: rmnet: Size the first device from the requested data format

This commit moves the IFLA_RMNET_FLAGS merge in rmnet_newlink() so it
runs before rmnet_vnd_newlink(), and passes the resulting data format
down. The new device's MTU is then computed from the egress headroom of
the requested format, not from the format already stored in the port.

> net: qualcomm: rmnet: Size the first device from the requested data format
>
> rmnet_newlink() sizes the first rmnet device from the data format
> currently stored in the port, before the requested IFLA_RMNET_FLAGS
> have been applied. The MTU therefore does not match the egress header
> overhead of the format which ends up being used.

[Severity: Low]
This isn't a bug, but is the "first device" wording narrower than what
the patch does?

The reordering in rmnet_newlink() in
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c is not limited to the
case where port->nr_rmnet_devs == 0. Every newlink now merges
IFLA_RMNET_FLAGS into the local data_format first, then sizes its device
from it:

err = rmnet_vnd_newlink(mux_id, dev, port, real_dev, ep, extack,
data_format);

Before this patch, a second or later device on the same real_dev got its
initial MTU from the port-wide format left by the previous newlink.

After this patch, that device is sized from its own requested flags. If
no flags are given, it is sized from RMNET_FLAGS_INGRESS_DEAGGREGATION
alone. Its default MTU can therefore differ by the size of the checksum
header (no checksum vs CKSUMV4/V5).

The message also doesn't say that port->data_format is a single setting
for the whole port, and that every newlink overwrites it.

Could the subject and body say that every device created through
rmnet_newlink() is affected, not only the first one?

--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117060737.2764327-1-subash.a.kasiviswanathan%40oss.qualcomm.com