Re: [PATCH] x86/cpu/hygon: Work around XSAVES Erratum 1386
From: Borislav Petkov
Date: Sat Nov 21 2026 - 02:15:16 EST
On Sat, Nov 21, 2026 at 02:46:31PM +0800, Tina Zhang wrote:
> I'll extend the existing erratum_1386_microcode[] table with the Hygon
> entries and make Hygon reuse fix_erratum_1386() instead of duplicating the
> workaround in hygon.c.
Sorry that I couldn't jump in here earlier. Those folks are all giving you
confusing ideas, don't listen to them... :)
You simply need to copy the amd.c code and adjust it with your numbers.
The reason why we're copying and not sharing code with AMD is because AMD
cannot test on Hygon and thus risk breaking Hygon or you vice versa.
So we have it all separate, that's why there's a cpu/hygon.c.
Once it all settles and once we absolutely cannot live with the mini code
duplication this causes, then we can start unifying.
But that time hasn't come yet. For now we will do all separate.
Thanks and sorry again that I couldn't jump in in time.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette