[PATCH v2] drm/i915/vma: Fix a memory leak in i915_vma_pin_ww()
From: Haoxiang Li
Date: Sat Nov 21 2026 - 02:19:04 EST
The memory allocated by i915_vma_work() is not freed if
i915_gem_object_get_moving_fence() fails. Change the
goto label to do so.
Fixes: 8ec5c0006c50 ("Merge tag 'drm-intel-next-2022-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-gt-next")
Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
---
Changes in v2:
- Modify the commit message. Thanks, Andi!
---
drivers/gpu/drm/i915/i915_vma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 16782d8579a8..4ba1c9ea5ecb 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -1470,7 +1470,7 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,
err = i915_gem_object_get_moving_fence(vma->obj, &moving);
if (err)
- goto err_rpm;
+ goto err_fence;
dma_fence_work_chain(&work->base, moving);
--
2.25.1