Re: [PATCH v4 3/5] phy: core: Add phy bulk data helper functions
From: Inochi Amaoto
Date: Sat Nov 21 2026 - 02:53:36 EST
On Tue, Sep 29, 2026 at 04:52:33PM +0800, Inochi Amaoto wrote:
> Add several helper functions that allow drivers to get several phy
> consumers in one operation. If any of the phy cannot be acquired then
> any phys that were got will be put before returning to the caller.
>
> This can relieve the driver owners' life who needs to handle many phys,
> as well as each phy error reporting.
>
> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> ---
> drivers/phy/phy-core.c | 253 ++++++++++++++++++++++++++++++++++++++++
> include/linux/phy/phy.h | 55 +++++++++
> 2 files changed, 308 insertions(+)
>
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index 8fbaea003b90..5b76c006575b 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -1004,6 +1004,259 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,
> }
> EXPORT_SYMBOL_GPL(devm_of_phy_get_by_index);
[...]
> +/**
> + * phy_bulk_init() - initialize multiple PHYs
> + * @num_phys: number of entries in the phys array
> + * @phys: array of struct phy_bulk_data to initialize
> + *
> + * Initializes the PHYs in array order. If an initialization fails, all PHYs
> + * initialized by this call are exited in reverse order.
> + *
> + * Return: %0 if successful, a negative error code otherwise
> + */
> +int phy_bulk_init(unsigned int num_phys, struct phy_bulk_data *phys)
> +{
> + unsigned int i;
> + int ret;
> +
> + for (i = 0; i < num_phys; i++) {
> + ret = phy_init(phys[i].phy);
> + if (ret)
> + goto err;
> + }
> +
> + return 0;
> +
> +err:
> + while (i--)
> + phy_exit(phys[i].phy);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_bulk_init);
> +
> +/**
> + * phy_bulk_exit() - exit multiple PHYs
> + * @num_phys: number of entries in the phys array
> + * @phys: array of struct phy_bulk_data to exit
> + *
> + * Exits the PHYs in reverse array order. All PHYs are processed even if an
> + * error occurs.
> + *
> + * Return: %0 if successful, the first negative error code otherwise
> + */
> +int phy_bulk_exit(unsigned int num_phys, struct phy_bulk_data *phys)
> +{
> + int ret = 0;
> + int err;
> +
> + while (num_phys--) {
> + err = phy_exit(phys[num_phys].phy);
> + if (err && !ret)
> + ret = err;
> + }
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_bulk_exit);
> +
Hi Vinod, Vladimir and Manivannan,
Before sending the next patch (I guess I can update it in the next
week), I have a question for the error handle.
As the phy_exit()/phy_power_off()/phy_power_on() can return an
error code, should the corresponding bulk api need to call the
corresponding phy_init()/phy_power_on()/phy_power_off() when
there is an error occurs. Or just leave the state as it is.
I saw the reset subsystem does this rollback.
Regards,
Inochi