Re: [PATCH net v10 05/10] can: rockchip_canfd: cancel bus-off restart before closing the device

From: Cunhao Lu

Date: Sat Nov 21 2026 - 02:56:16 EST


Hi,

> [Severity: Low]
> Is this explanation complete? Late-queued restart work does not have to
> wait for the final cancel. With a short restart_ms it can run anywhere
> between the early cancel and close_candev().
>
> [...]
>
> Could the commit message say that late work which runs before the final
> cancel is stopped by the netif_running() check in can_restart()? Could
> the netif_running() patch also be listed as a stable prerequisite?

Yes, that distinction matters. It needs 03/10 as well. Both
prerequisites are already marked for stable in this series, so the
stable rules do not require another prerequisite tag here.

Best regards,
Cunhao Lu