Re: [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints
From: Krzysztof Kozlowski
Date: Sat Nov 21 2026 - 04:26:06 EST
On Fri, Nov 20, 2026 at 06:50:50PM +0530, Komal Bajaj wrote:
> The number of IOMMU streams used by a remote processor is not necessarily
> limited to one. On Shikra, LPAICP uses three streams, while CDSP uses one
> and MPSS does not use any. The existing single-entry limit therefore cannot
> describe the LPAICP firmware streams.
>
> Increase the maximum number of iommus entries to three and constrain it per
> compatible: require three entries for qcom,shikra-lpaicp-pas, allow only
> one for qcom,shikra-cdsp-pas, and disallow the property for
> qcom,shikra-mpss-pas.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> ---
> .../bindings/remoteproc/qcom,shikra-pas.yaml | 24 +++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> index 74f83b7ce08d..3b827f2aadb4 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> @@ -92,7 +92,8 @@ properties:
> description:
> IOMMU specifiers of the streams used by the remote processor
> firmware for its memory accesses.
> - maxItems: 1
> + minItems: 1
> + maxItems: 3
Review from v4 still applies, you need to list the items, either here
(if devices share the list) or in if:then: part.
Best regards,
Krzysztof