[PATCH v2 0/3] media: stateless MPEG-1 decoding, cedrus support
From: Arun Iyengar via B4 Relay
Date: Sat Nov 21 2026 - 05:11:01 EST
Builds on Jernej Skrabec's cedrus work; tested with an FFmpeg hwaccel
on top of Jonas Karlman's V4L2 request API series (FFmpeg PR 20847).
MPEG-1 decoded as MPEG-2 is wrong: the mismatch control differs, and
MPEG-1 has full pel motion vectors and D-pictures. Patch 1 adds
V4L2_MPEG2_SEQ_FLAG_MPEG1 and two full pel picture flags to the MPEG-2
controls and allows D-pictures; patch 2 makes hantro reject them
(compile tested only). Patch 3 implements them in cedrus.
Tested on H616 only, on media-committers next: MPEG-2, H.264 and H.265
decode bit-exact against FFmpeg software decoding. MPEG-1 streams with
B-pictures and full pel vectors differ from FFmpeg (-idct faani) by at
most 2 in I-, P- and B-pictures; FFmpeg's own IDCTs differ by up to 3
on the same streams. The full pel reference needs an FFmpeg fix for
skipped B macroblocks. MPEG-1 D-pictures are bit-exact against a
computed DC reference; stock v4l2-compliance 49 of 49.
Developed with Claude (Anthropic) as a coding assistant, which wrote
the code and the commit messages. I reviewed and tested them as
described above.
Changes in v2:
- Drop V4L2_PIX_FMT_MPEG1_SLICE: cedrus selects MPEG-1 from
V4L2_MPEG2_SEQ_FLAG_MPEG1 alone (Nicolas)
- hantro reject in its own patch
- Link to v1: https://lore.kernel.org/r/20261119-b4-cedrus-mpeg1-v1-0-aa5ba1192822@xxxxxxxxx
---
Arun Iyengar (3):
media: uapi: mpeg2: add MPEG-1 flags
media: verisilicon: reject MPEG-1 controls
media: cedrus: mpeg2: decode MPEG-1
.../media/v4l/ext-ctrls-codec-stateless.rst | 34 ++++++++++++++++++++--
drivers/media/platform/verisilicon/hantro_drv.c | 12 ++++++++
drivers/media/v4l2-core/v4l2-ctrls-core.c | 1 +
drivers/staging/media/sunxi/cedrus/cedrus.h | 3 ++
drivers/staging/media/sunxi/cedrus/cedrus_mpeg2.c | 27 ++++++++++++++---
include/uapi/linux/v4l2-controls.h | 3 ++
6 files changed, 74 insertions(+), 6 deletions(-)
---
base-commit: ccf78740d63813c452c035b57d17a650492562fa
change-id: 20261114-b4-cedrus-mpeg1-8baae5a2eefe
Best regards,
--
Arun Iyengar <aiyengar1990@xxxxxxxxx>