Re: [PATCH net-next v5 4/9] dt-bindings: mfd: Add SoC-e SWIP parent
From: Krzysztof Kozlowski
Date: Sat Nov 21 2026 - 05:19:57 EST
On Fri, Nov 20, 2026 at 03:52:21PM +0100, Vasilij Strassheim wrote:
> +examples:
> + - |
> + ip-core@80020000 {
> + compatible = "soce,swip";
> + reg = <0x80020000 0x10000>;
> + ranges = <0x0 0x80020000 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + ethernet-switch@0 {
> + compatible = "soce,swip-switch-00-04-0c-10";
> + reg = <0x0 0x10000>;
You have conflicting address spaces - this covers all other children -
which suggests this is artificial split of device nodes. Basically
comments from last version are valid. If some split of device nodes
makes your driver easier, it might be fine, but only under the
constraint of proper hardware representation. It's not proper hardware
representation anymore.
Best regards,
Krzysztof