Re: [PATCH wireless-next v5 4/4] wifi: aic: Integrate the AIC8800 SDIO driver
From: 杨彦立
Date: Sat Nov 21 2026 - 05:33:26 EST
Thanks for the review.
> So all these five people will be providing reviews, right? Just don't
> add random managers names?
Yes, all five people listed here are technical engineers who will actively review patches and maintain this driver. No non-technical managers are added.
> Bindings as well
I will add the binding to the MAINTAINERS entry:
F: Documentation/devicetree/bindings/net/wireless/aicsemi,aic8800d80-fmac.yaml
> Why this cannot be previous patch? Why Makefile entry has to be a
> separate commit?
Agreed. The intention was to keep the driver unselectable until all
sources were present, but folding this patch into patch 3 achieves
the same result. Patch 3 already adds the remaining implementation
and the driver-local Kconfig and Makefiles.
I will fold this patch, including the MAINTAINERS entry, into patch 3
in v6 and update the cover letter accordingly.
Best regards,
Yanli
> From: "Krzysztof Kozlowski"<krzk@xxxxxxxxxx>
> Date: Mon, Nov 16, 2026, 19:10
> Subject: Re: [PATCH wireless-next v5 4/4] wifi: aic: Integrate the AIC8800 SDIO driver
> To: "Yanli Yang"<yanli.yang@xxxxxxxxxx>
> Cc: <linux-wireless@xxxxxxxxxxxxxxx>, "Johannes Berg"<johannes@xxxxxxxxxxxxxxxx>, "Rob Herring"<robh@xxxxxxxxxx>, "Krzysztof Kozlowski"<krzk+dt@xxxxxxxxxx>, "Conor Dooley"<conor+dt@xxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, "Zhirun Liu"<zhirunliu@xxxxxxxxxxx>, "Dijia Xu"<dijiaxu@xxxxxxxxxxx>, "Chunqiu Liu"<chunqiuliu@xxxxxxxxxxx>, "Liheng Wei"<liheng.wei@xxxxxxxxxx>
> On Mon, Nov 16, 2026 at 03:23:22PM +0800, Yanli Yang wrote:
> > From: Zhirun Liu <zhirunliu@xxxxxxxxxxx>
> >
> > Connect the AIC vendor directory to the wireless Kconfig and Makefile
> > so the complete AIC8800D80 and AIC8800D80N FullMAC driver can be selected.
> >
> > Add the driver maintainers, reviewers and linux-wireless mailing list to
> > MAINTAINERS. Keep the parent build integration last so that intermediate
> > patches do not expose an incomplete driver configuration.
> >
> > Signed-off-by: Chunqiu Liu <chunqiuliu@xxxxxxxxxxx>
> > Signed-off-by: Zhirun Liu <zhirunliu@xxxxxxxxxxx>
> > Signed-off-by: Yanli Yang <yanli.yang@xxxxxxxxxx>
> > ---
> > MAINTAINERS | 10 ++++++++++
> > drivers/net/wireless/Kconfig | 1 +
> > drivers/net/wireless/Makefile | 1 +
> > 3 files changed, 12 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7336600952c8..4e327fd62b26 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -746,6 +746,16 @@ L: linux-scsi@xxxxxxxxxxxxxxx
> > S: Maintained
> > F: drivers/scsi/aic7xxx/
> >
> > +AIC8800 WIRELESS DRIVER
> > +M: Zhirun Liu <zhirunliu@xxxxxxxxxxx>
> > +M: Dijia Xu <dijiaxu@xxxxxxxxxxx>
> > +M: Chunqiu Liu <chunqiuliu@xxxxxxxxxxx>
> > +R: Liheng Wei <liheng.wei@xxxxxxxxxx>
> > +R: Yanli Yang <yanli.yang@xxxxxxxxxx>
>
> So all these five people will be providing reviews, right? Just don't
> add random managers names?
>
> > +L: linux-wireless@xxxxxxxxxxxxxxx
> > +S: Maintained
> > +F: drivers/net/wireless/aic/
>
> Bindings as well
>
> > +
> > AIMSLAB FM RADIO RECEIVER DRIVER
> > M: Hans Verkuil <hverkuil@xxxxxxxxxx>
> > L: linux-media@xxxxxxxxxxxxxxx
> > diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
> > index f4f969fdbc02..964e633898ca 100644
> > --- a/drivers/net/wireless/Kconfig
> > +++ b/drivers/net/wireless/Kconfig
> > @@ -19,6 +19,7 @@ menuconfig WLAN
> > if WLAN
> >
> > source "drivers/net/wireless/admtek/Kconfig"
> > +source "drivers/net/wireless/aic/Kconfig"
> > source "drivers/net/wireless/ath/Kconfig"
> > source "drivers/net/wireless/atmel/Kconfig"
> > source "drivers/net/wireless/broadcom/Kconfig"
> > diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile
> > index fa3100ff3bf7..47b999e8014c 100644
> > --- a/drivers/net/wireless/Makefile
> > +++ b/drivers/net/wireless/Makefile
> > @@ -4,6 +4,7 @@
> > #
> >
> > obj-$(CONFIG_WLAN_VENDOR_ADMTEK) += admtek/
> > +obj-$(CONFIG_WLAN_VENDOR_AIC) += aic/
>
> Why this cannot be previous patch? Why Makefile entry has to be a
> separate commit?
>
> > obj-$(CONFIG_WLAN_VENDOR_ATH) += ath/
> > obj-$(CONFIG_WLAN_VENDOR_ATMEL) += atmel/
> > obj-$(CONFIG_WLAN_VENDOR_BROADCOM) += broadcom/
>