Re: [PATCH 1/3] arm64: pi: Add an ISB after mapping the FDT in the initial ID map

From: Ryan Roberts

Date: Sat Nov 21 2026 - 05:42:22 EST


On 20/11/2026 12:16, Fuad Tabba wrote:
> map_fdt() maps the FDT into the live initial ID map with only a DSB
> before the caller reads it, so the read can fault on a translation made
> speculatively before the mapping was written. This early in boot,
> VBAR_EL1 doesn't yet point at the kernel's vectors, and the kernel fails
> to boot.
>
> Add an ISB after the DSB.
>
> Fixes: 84b04d3e6bdbc ("arm64: kernel: Create initial ID map from C code")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>

I did a quick audit of all the other DSBs without ISBs in the pi code and I
think the rest are all correct because they are not synchronising stores to
_live_ tables so there can't have been any speculation with the old invalid value.

Reviewed-by: Ryan Roberts <ryan.roberts@xxxxxxx>



> ---
> arch/arm64/kernel/pi/map_kernel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/pi/map_kernel.c b/arch/arm64/kernel/pi/map_kernel.c
> index fb44cbdd2f292..f9338257adb7d 100644
> --- a/arch/arm64/kernel/pi/map_kernel.c
> +++ b/arch/arm64/kernel/pi/map_kernel.c
> @@ -211,6 +211,7 @@ static void *__init map_fdt(phys_addr_t fdt)
> fdt, PAGE_KERNEL, IDMAP_ROOT_LEVEL,
> (pte_t *)init_idmap_pg_dir, false, 0);
> dsb(ishst);
> + isb();
>
> return (void *)fdt;
> }